Merged
Conversation
zhaohuabing
force-pushed
the
1.4-docs
branch
2 times, most recently
from
8e0d520 to
b54d8c3
Compare
zhaohuabing
commented
May 14, 2025
Member
Author
There was a problem hiding this comment.
The links in the generated gateway api docs are not correct. They should point to the Gateway API website.
zhaohuabing
commented
May 14, 2025
tools/make/docs.mk
Outdated
Member
Author
There was a problem hiding this comment.
Remove this in order to:
- Better control the eol date
- Avoid generating multiple duplicated parms versions when running
make docs-releasemultiple times.
Will add this in the release doc in a seperate PR.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6052 +/- ##
==========================================
- Coverage 70.40% 70.39% -0.01%
==========================================
Files 217 217
Lines 36171 36171
==========================================
- Hits 25466 25463 -3
- Misses 9184 9186 +2
- Partials 1521 1522 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zhaohuabing
force-pushed
the
1.4-docs
branch
4 times, most recently
from
b3735d6 to
7210117
Compare
Member
Author
|
Some of the links in the gateway api docs are manually fixed. Tracked it in issue: #6061 |
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
zhaohuabing
force-pushed
the
1.4-docs
branch
2 times, most recently
from
e0db637 to
68e2cf2
Compare
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
arkodg
previously approved these changes
May 14, 2025
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
shawnh2
approved these changes
May 14, 2025
zirain
approved these changes
May 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.