Merged
Conversation
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
zirain
reviewed
May 14, 2025
| __Note:__ In case your Kubernetes cluster does not have a LoadBalancer implementation, we recommend installing one | ||
| so the `Gateway` resource has an Address associated with it. We recommend using [MetalLB](https://metallb.universe.tf/installation/). | ||
|
|
||
| __Note:__ For Mac user, you need install and run [Docker Mac Net Connect](https://github.com/chipmk/docker-mac-net-connect) to make the Docker network work. |
Contributor
Author
There was a problem hiding this comment.
its distracting for an end user, its tied to mac and docker and kind, for e.g. on mac, i use docker desktop and this isnt needed, this note is needed in developer docs, when running e2e on kind on mac
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6051 +/- ##
==========================================
- Coverage 70.40% 70.36% -0.04%
==========================================
Files 217 217
Lines 36171 36171
==========================================
- Hits 25465 25453 -12
- Misses 9185 9193 +8
- Partials 1521 1525 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zirain
approved these changes
May 14, 2025
zhaohuabing
approved these changes
May 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.