Skip to content

fix: avoid appending same Backends twice to resource map #6021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mathetake wants to merge 3 commits into from
Closed

fix: avoid appending same Backends twice to resource map #6021

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
74cc2e0
fix: avoid appending same Backends twice to resource map
mathetake May 12, 2025
ae6137e
more
mathetake May 12, 2025
695368e
rm
mathetake May 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 0 additions & 24 deletions internal/provider/kubernetes/controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,13 +290,6 @@ func (r *gatewayAPIReconciler) Reconcile(ctx context.Context, _ reconcile.Reques
continue
}

if r.backendCRDExists {
if err = r.processBackends(ctx, gwcResource); err != nil {
r.log.Error(err, fmt.Sprintf("failed processBackends for gatewayClass %s, skipping it", managedGC.Name))
continue
}
}

// Add the referenced services, ServiceImports, and EndpointSlices in
// the collected BackendRefs to the resourceTree.
// BackendRefs are referred by various Route objects and the ExtAuth in SecurityPolicies.
Expand Down Expand Up @@ -1304,23 +1297,6 @@ func (r *gatewayAPIReconciler) processBackendTLSPolicies(
return nil
}

// processBackends adds Backends to the resourceTree
func (r *gatewayAPIReconciler) processBackends(ctx context.Context, resourceTree *resource.Resources) error {
backends := egv1a1.BackendList{}
if err := r.client.List(ctx, &backends); err != nil {
return fmt.Errorf("error listing Backends: %w", err)
}

for _, backend := range backends.Items {
backend := backend //nolint:copyloopvar
// Discard Status to reduce memory consumption in watchable
// It will be recomputed by the gateway-api layer
backend.Status = egv1a1.BackendStatus{}
resourceTree.Backends = append(resourceTree.Backends, &backend)
}
return nil
}

// removeFinalizer removes the gatewayclass finalizer from the provided gc, if it exists.
func (r *gatewayAPIReconciler) removeFinalizer(ctx context.Context, gc *gwapiv1.GatewayClass) error {
if slice.ContainsString(gc.Finalizers, gatewayClassFinalizer) {
Expand Down
Loading