Skip to content

e2e: add CollectAndDump for EGUpgrade test #5998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zirain merged 3 commits into from
May 12, 2025
Merged

e2e: add CollectAndDump for EGUpgrade test #5998

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5f2f360
e2e: only run collect and dump when failed
zirain May 11, 2025
48ac915
dump when EGUpgrade failed
zirain May 11, 2025
e4d4188
nit
zirain May 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions test/e2e/tests/eg_upgrade.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,11 @@ var EGUpgradeTest = suite.ConformanceTest{
t.Errorf("failed to get expected response for the first three requests: %v", err)
}
})
t.Cleanup(func() {
if t.Failed() {
CollectAndDump(t, suite.RestConfig)
}
})
},
}

Expand Down
6 changes: 4 additions & 2 deletions test/e2e/tests/merge_gateways.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,8 +246,10 @@ var MergeGatewaysTest = suite.ConformanceTest{

// Clean-up the conflicted gateway and route resources.
t.Cleanup(func() {
// Collect and dump every config before removing the created resource.
CollectAndDump(t, suite.RestConfig)
if t.Failed() {
// Collect and dump every config before removing the created resource.
CollectAndDump(t, suite.RestConfig)
}

conflictedGateway := new(gwapiv1.Gateway)
conflictedHTTPRoute := new(gwapiv1.HTTPRoute)
Expand Down
Loading