Skip to content

Revert "e2e: test for dynamic resolver backend using system ca for TLS"#5959

Closed
zirain wants to merge 1 commit intomainfrom
revert-5932-e2e-dynamic-resolver
Closed

Revert "e2e: test for dynamic resolver backend using system ca for TLS"#5959
zirain wants to merge 1 commit intomainfrom
revert-5932-e2e-dynamic-resolver

Conversation

@zirain
Copy link
Member

@zirain zirain commented May 8, 2025

Reverts #5932

@zirain zirain requested a review from a team as a code owner May 8, 2025 06:43
@zirain
Copy link
Member Author

zirain commented May 8, 2025

xref: #5956

#5932)"

This reverts commit 6b772d7.

Signed-off-by: zirain <zirain2009@gmail.com>
@zirain zirain force-pushed the revert-5932-e2e-dynamic-resolver branch from ed4f2dc to a5aed4e Compare May 8, 2025 06:44
@zhaohuabing
Copy link
Member

It only fails in IPv6, or fail in both IPv4 and IPv6?

@zirain
Copy link
Member Author

zirain commented May 8, 2025

@zhaohuabing
Copy link
Member

zhaohuabing commented May 8, 2025

Can we just disable it for IPv6 before we figure out why it's flaky in IPv6?

@codecov
Copy link

codecov bot commented May 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.78%. Comparing base (2bbbdf8) to head (a5aed4e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5959      +/-   ##
==========================================
- Coverage   65.80%   65.78%   -0.02%     
==========================================
  Files         217      217              
  Lines       36013    36013              
==========================================
- Hits        23699    23692       -7     
- Misses      10834    10840       +6     
- Partials     1480     1481       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Xunzhuo
Copy link
Member

Xunzhuo commented May 8, 2025

Can we just disable it for IPv6 before we figure out why it's flaky in IPv6?

+1

@zirain
Copy link
Member Author

zirain commented May 8, 2025

Can we just disable it for IPv6 before we figure out why it's flaky in IPv6?

you can send another PR.

@zhaohuabing
Copy link
Member

Can we just disable it for IPv6 before we figure out why it's flaky in IPv6?

you can send another PR.

#5964

@zirain zirain closed this May 8, 2025
@zirain zirain deleted the revert-5932-e2e-dynamic-resolver branch May 8, 2025 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants