Skip to content

feat: support app protocol for dynamic resolver backend#5936

Merged
guydc merged 3 commits intoenvoyproxy:mainfrom
zhaohuabing:dynamic-resolver-app-protocol
May 23, 2025
Merged

feat: support app protocol for dynamic resolver backend#5936
guydc merged 3 commits intoenvoyproxy:mainfrom
zhaohuabing:dynamic-resolver-app-protocol

Conversation

@zhaohuabing
Copy link
Member

part of #3560

@zhaohuabing zhaohuabing requested a review from a team as a code owner May 6, 2025 08:27
@zhaohuabing zhaohuabing force-pushed the dynamic-resolver-app-protocol branch 2 times, most recently from d063c08 to c39ea3d Compare May 6, 2025 09:13
@zhaohuabing zhaohuabing marked this pull request as draft May 6, 2025 09:21
@zhaohuabing zhaohuabing force-pushed the dynamic-resolver-app-protocol branch from c39ea3d to 8a22b2f Compare May 6, 2025 09:36
@zhaohuabing zhaohuabing marked this pull request as ready for review May 6, 2025 09:38
@zhaohuabing zhaohuabing force-pushed the dynamic-resolver-app-protocol branch from 8a22b2f to 00cba2a Compare May 6, 2025 09:46
@codecov
Copy link

codecov bot commented May 6, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 70.46%. Comparing base (6b772d7) to head (96789b5).
Report is 98 commits behind head on main.

Files with missing lines Patch % Lines
internal/gatewayapi/backend.go 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5936      +/-   ##
==========================================
+ Coverage   65.29%   70.46%   +5.16%     
==========================================
  Files         216      217       +1     
  Lines       35907    36197     +290     
==========================================
+ Hits        23445    25505    +2060     
+ Misses      11007     9175    -1832     
- Partials     1455     1517      +62     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zhaohuabing zhaohuabing force-pushed the dynamic-resolver-app-protocol branch from 00cba2a to 2d2cd92 Compare May 6, 2025 12:57
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
@zhaohuabing zhaohuabing force-pushed the dynamic-resolver-app-protocol branch from 2d2cd92 to 1f7bdf9 Compare May 7, 2025 03:32
@zhaohuabing zhaohuabing requested a review from a team May 7, 2025 03:45
@zhaohuabing zhaohuabing added this to the v1.4.0 milestone May 9, 2025
@arkodg arkodg modified the milestones: v1.4.0, Backlog May 13, 2025
@zhaohuabing zhaohuabing modified the milestone: Backlog May 16, 2025
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
@zhaohuabing zhaohuabing requested a review from rudrakhp May 20, 2025 02:54
@zhaohuabing zhaohuabing requested review from a team May 21, 2025 00:29
@guydc guydc merged commit b18e5b6 into envoyproxy:main May 23, 2025
44 of 45 checks passed
@zhaohuabing zhaohuabing deleted the dynamic-resolver-app-protocol branch May 24, 2025 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants