Skip to content

feat: cluster stat name#5898

Merged
arkodg merged 14 commits intoenvoyproxy:mainfrom
guydc:feat-cluster-alt-stat-name
Jun 11, 2025
Merged

feat: cluster stat name#5898
arkodg merged 14 commits intoenvoyproxy:mainfrom
guydc:feat-cluster-alt-stat-name

Conversation

@guydc
Copy link
Contributor

@guydc guydc commented May 1, 2025

What type of PR is this?

What this PR does / why we need it:
Add support for determining cluster stat names in EnvoyProxy.

  • Supported Clusters: HTTPRoute and GRPCRoute
  • Supported Formatters: %ROUTE_KIND%, %ROUTE_NAME%, %ROUTE_NAMESPACE%, %ROUTE_RULE_NAME%, %ROUTE_RULE_NUMBER%, %BACKEND_REFS%.

Which issue(s) this PR fixes:

Relates #4717

Release Notes: Yes

@codecov
Copy link

codecov bot commented May 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.57%. Comparing base (598c813) to head (8f59cd5).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5898      +/-   ##
==========================================
+ Coverage   70.49%   70.57%   +0.07%     
==========================================
  Files         220      220              
  Lines       36639    36703      +64     
==========================================
+ Hits        25830    25904      +74     
+ Misses       9281     9273       -8     
+ Partials     1528     1526       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@guydc guydc marked this pull request as ready for review May 2, 2025 11:33
@guydc guydc requested a review from a team as a code owner May 2, 2025 11:33
@DerrickMartinez
Copy link

Thanks for doing this. What is the latest with this PR?

@guydc
Copy link
Contributor Author

guydc commented May 13, 2025

@DerrickMartinez - Post the 1.4 release (hopefully this week), maintainers should have more bandwidth to push this forward in the 1.5 scope. Thanks for expressing interest, this helps prioritize the issue.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we split this up into ROUTE_NAME and ROUTE_NAMESPACE ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or ROUTE_RULE_NAME ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Only HTTPRoute and GRPCRoute clusters are currently supported.
// Only xDS Clusters created by HTTPRoute and GRPCRoute resources are currently supported.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add an example of this here ?

guydc added 6 commits June 6, 2025 10:37
Signed-off-by: Guy Daich <guy.daich@sap.com>
Signed-off-by: Guy Daich <guy.daich@sap.com>
Signed-off-by: Guy Daich <guy.daich@sap.com>
Signed-off-by: Guy Daich <guy.daich@sap.com>
Signed-off-by: Guy Daich <guy.daich@sap.com>
Signed-off-by: Guy Daich <guy.daich@sap.com>
@guydc guydc force-pushed the feat-cluster-alt-stat-name branch from c5960d5 to 2441e66 Compare June 6, 2025 19:55
Signed-off-by: Guy Daich <guy.daich@sap.com>
@arkodg
Copy link
Contributor

arkodg commented Jun 6, 2025

LGTM thanks, one comment around the CEL test which is removing the older one

guydc added 3 commits June 6, 2025 16:29
Signed-off-by: Guy Daich <guy.daich@sap.com>
Signed-off-by: Guy Daich <guy.daich@sap.com>
arkodg
arkodg previously approved these changes Jun 6, 2025
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.thanks !

@arkodg arkodg requested a review from a team June 6, 2025 21:45
@arkodg arkodg requested a review from a team June 6, 2025 21:45
Signed-off-by: Guy Daich <guy.daich@sap.com>
arkodg
arkodg previously approved these changes Jun 6, 2025
@arkodg arkodg requested review from a team June 6, 2025 22:00
Signed-off-by: Guy Daich <guy.daich@sap.com>
guydc added 2 commits June 9, 2025 16:09
Signed-off-by: Guy Daich <guy.daich@sap.com>
@guydc guydc requested a review from arkodg June 9, 2025 22:55
@arkodg arkodg requested review from a team June 9, 2025 23:01
@arkodg arkodg merged commit 9c701f6 into envoyproxy:main Jun 11, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants