Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5898 +/- ##
==========================================
+ Coverage 70.49% 70.57% +0.07%
==========================================
Files 220 220
Lines 36639 36703 +64
==========================================
+ Hits 25830 25904 +74
+ Misses 9281 9273 -8
+ Partials 1528 1526 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks for doing this. What is the latest with this PR? |
|
@DerrickMartinez - Post the 1.4 release (hopefully this week), maintainers should have more bandwidth to push this forward in the 1.5 scope. Thanks for expressing interest, this helps prioritize the issue. |
2b60993 to
bf8d44d
Compare
There was a problem hiding this comment.
should we split this up into ROUTE_NAME and ROUTE_NAMESPACE ?
There was a problem hiding this comment.
| // Only HTTPRoute and GRPCRoute clusters are currently supported. | |
| // Only xDS Clusters created by HTTPRoute and GRPCRoute resources are currently supported. |
There was a problem hiding this comment.
can we add an example of this here ?
Signed-off-by: Guy Daich <guy.daich@sap.com>
Signed-off-by: Guy Daich <guy.daich@sap.com>
c5960d5 to
2441e66
Compare
Signed-off-by: Guy Daich <guy.daich@sap.com>
|
LGTM thanks, one comment around the CEL test which is removing the older one |
Signed-off-by: Guy Daich <guy.daich@sap.com>
Signed-off-by: Guy Daich <guy.daich@sap.com>
Signed-off-by: Guy Daich <guy.daich@sap.com>
Signed-off-by: Guy Daich <guy.daich@sap.com>
What type of PR is this?
What this PR does / why we need it:
Add support for determining cluster stat names in EnvoyProxy.
%ROUTE_KIND%,%ROUTE_NAME%,%ROUTE_NAMESPACE%,%ROUTE_RULE_NAME%,%ROUTE_RULE_NUMBER%,%BACKEND_REFS%.Which issue(s) this PR fixes:
Relates #4717
Release Notes: Yes