Skip to content

disable settings by default in gateway-crds-helm #5894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arkodg merged 4 commits into from
May 2, 2025
Merged

disable settings by default in gateway-crds-helm #5894

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2fecc8b
disable settings by default in gateway-crds-helm
May 1, 2025
610779c
lint
May 1, 2025
6bf2512
another hack
May 1, 2025
44a05ce
skip spellcheck in test/helm
May 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions charts/gateway-crds-helm/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,6 @@ To uninstall the chart:

| Key | Type | Default | Description |
|-----|------|---------|-------------|
| crds.envoyGateway.enabled | bool | `true` | |
| crds.gatewayAPI.enabled | bool | `true` | |
| crds.envoyGateway.enabled | bool | `false` | |
| crds.gatewayAPI.enabled | bool | `false` | |

4 changes: 2 additions & 2 deletions charts/gateway-crds-helm/values.tmpl.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
crds:
gatewayAPI:
enabled: true
enabled: false
envoyGateway:
enabled: true
enabled: false
4 changes: 2 additions & 2 deletions charts/gateway-crds-helm/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
crds:
gatewayAPI:
enabled: true
enabled: false
envoyGateway:
enabled: true
enabled: false
4 changes: 2 additions & 2 deletions site/content/en/latest/install/gateway-crds-helm-api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,6 @@ A Helm chart for Kubernetes

| Key | Type | Default | Description |
|-----|------|---------|-------------|
| crds.envoyGateway.enabled | bool | `true` | |
| crds.gatewayAPI.enabled | bool | `true` | |
| crds.envoyGateway.enabled | bool | `false` | |
| crds.gatewayAPI.enabled | bool | `false` | |

5 changes: 5 additions & 0 deletions test/helm/gateway-crds-helm/all.in.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
crds:
gatewayAPI:
enabled: true
envoyGateway:
enabled: true
43,461 changes: 43,461 additions & 0 deletions test/helm/gateway-crds-helm/all.out.yaml
View file
Open in desktop

Large diffs are not rendered by default.

5 changes: 5 additions & 0 deletions test/helm/gateway-crds-helm/default.in.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
crds:
gatewayAPI:
enabled: false
envoyGateway:
enabled: false
1 change: 1 addition & 0 deletions test/helm/gateway-crds-helm/default.out.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@

5 changes: 5 additions & 0 deletions test/helm/gateway-crds-helm/envoy-gateway-crds.in.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
crds:
gatewayAPI:
enabled: false
envoyGateway:
enabled: true
26,130 changes: 26,130 additions & 0 deletions test/helm/gateway-crds-helm/envoy-gateway-crds.out.yaml
View file
Open in desktop

Large diffs are not rendered by default.

5 changes: 5 additions & 0 deletions test/helm/gateway-crds-helm/gateway-api-crds.in.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
crds:
gatewayAPI:
enabled: true
envoyGateway:
enabled: false
17,331 changes: 17,331 additions & 0 deletions test/helm/gateway-crds-helm/gateway-api-crds.out.yaml
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions tools/linter/codespell/.codespell.skip
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ go.mod
go.sum
bin
./charts
./test/helm/*
*.js
*/testdata/*.yaml
./site/public/*
Expand Down
6 changes: 4 additions & 2 deletions tools/linter/yamllint/.yamllint
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,11 @@ ignore: |
# the Install YAML in bin/
charts/gateway-helm/
charts/gateway-addons-helm/
charts/gateway-crds-helm
charts/gateway-crds-helm/
bin/install.yaml
test/helm/
test/helm/gateway-helm/
test/helm/gateway-addons-helm/
test/helm/gateway-crds-helm/
examples/extension-server/charts/extension-server
site/node_modules/

Expand Down
8 changes: 5 additions & 3 deletions tools/make/helm.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,9 +73,11 @@ helm-generate.%:
@for file in $(wildcard test/helm/${CHART_NAME}/*.in.yaml); do \
filename=$$(basename $${file}); \
output="$${filename%.in.*}.out.yaml"; \
if [ ${CHART_NAME} == "gateway-addons-helm" ]; then \
helm template ${CHART_NAME} charts/${CHART_NAME} -f $${file} > test/helm/${CHART_NAME}/$$output --namespace=monitoring; \
else \
if [ ${CHART_NAME} == "gateway-addons-helm" ]; then \
helm template ${CHART_NAME} charts/${CHART_NAME} -f $${file} > test/helm/${CHART_NAME}/$$output --namespace=monitoring; \
elif [ ${CHART_NAME} == "gateway-crds-helm" ]; then \
helm template ${CHART_NAME} charts/${CHART_NAME} -f $${file} > test/helm/${CHART_NAME}/$$output; \
else \
helm template ${CHART_NAME} charts/${CHART_NAME} -f $${file} > test/helm/${CHART_NAME}/$$output --namespace=envoy-gateway-system; \
fi; \
done
Loading