fix: make topology injector best effort#5891
Merged
arkodg merged 2 commits intoenvoyproxy:mainfrom May 1, 2025
Merged
Conversation
* allow pods even if there is an internal error in the webhook processing the request Relates to envoyproxy#5890 Signed-off-by: Arko Dasgupta <arko@tetrate.io>
guydc
previously approved these changes
May 1, 2025
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (60.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #5891 +/- ##
==========================================
+ Coverage 65.17% 65.20% +0.02%
==========================================
Files 224 224
Lines 35857 35857
==========================================
+ Hits 23370 23380 +10
+ Misses 11043 11034 -9
+ Partials 1444 1443 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
guydc
approved these changes
May 1, 2025
arkodg
added a commit
to arkodg/gateway
that referenced
this pull request
May 1, 2025
* fix: make topology injector best effort * allow pods even if there is an internal error in the webhook processing the request Relates to envoyproxy#5890 Signed-off-by: Arko Dasgupta <arko@tetrate.io> * fix build Signed-off-by: Arko Dasgupta <arko@tetrate.io> --------- Signed-off-by: Arko Dasgupta <arko@tetrate.io> (cherry picked from commit 5b8269d) Signed-off-by: Arko Dasgupta <arko@tetrate.io>
melsal13
referenced
this pull request
in melsal13/gatewayPersonal
May 7, 2025
* fix: make topology injector best effort * allow pods even if there is an internal error in the webhook processing the request Relates to envoyproxy/gateway#5890 Signed-off-by: Arko Dasgupta <arko@tetrate.io> * fix build Signed-off-by: Arko Dasgupta <arko@tetrate.io> --------- Signed-off-by: Arko Dasgupta <arko@tetrate.io> Signed-off-by: melsal13 <mmvsal13@gmail.com>
shawnh2
pushed a commit
to shawnh2/gateway
that referenced
this pull request
Sep 15, 2025
…) (envoyproxy#5895) fix: make topology injector best effort (envoyproxy#5891) * fix: make topology injector best effort * allow pods even if there is an internal error in the webhook processing the request Relates to envoyproxy#5890 * fix build --------- (cherry picked from commit 5b8269d) Signed-off-by: Arko Dasgupta <arko@tetrate.io> Signed-off-by: shawnh2 <shawnhxh@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #5890