Revert "increase liveness probe failureThreshold for shutdown manager…#5889
Merged
arkodg merged 1 commit intoenvoyproxy:mainfrom May 1, 2025
Merged
Revert "increase liveness probe failureThreshold for shutdown manager…#5889arkodg merged 1 commit intoenvoyproxy:mainfrom
arkodg merged 1 commit intoenvoyproxy:mainfrom
Conversation
…envoyproxy#5877)" This reverts commit 93f3d1c. This commit may introduce other subtle issues where the licenses probes for envoy kicks in but not shutdown manager which will block envoy from restarting, so prefer to not make this change atm. Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5889 +/- ##
=======================================
Coverage 65.17% 65.17%
=======================================
Files 224 224
Lines 35857 35857
=======================================
+ Hits 23370 23371 +1
Misses 11043 11043
+ Partials 1444 1443 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
guydc
approved these changes
May 1, 2025
melsal13
referenced
this pull request
in melsal13/gatewayPersonal
May 7, 2025
…… (#5889) Revert "increase liveness probe failureThreshold for shutdown manager (#5877)" This reverts commit 93f3d1c. This commit may introduce other subtle issues where the licenses probes for envoy kicks in but not shutdown manager which will block envoy from restarting, so prefer to not make this change atm. Signed-off-by: Arko Dasgupta <arko@tetrate.io> Signed-off-by: melsal13 <mmvsal13@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… (#5877)"
This reverts commit 93f3d1c.
This commit may introduce other subtle issues where the licenses probes for envoy kicks in but not shutdown manager which will block envoy from restarting, so prefer to not make this change atm.