fix: remove sanposhiho from reviewers#5870
Merged
arkodg merged 2 commits intoenvoyproxy:mainfrom May 1, 2025
Merged
Conversation
Signed-off-by: Kensei Nakada <handbomusic@gmail.com>
Member
Author
|
cc @arkodg |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5870 +/- ##
==========================================
- Coverage 65.16% 65.15% -0.02%
==========================================
Files 224 224
Lines 35857 35857
==========================================
- Hits 23368 23364 -4
- Misses 11043 11047 +4
Partials 1446 1446 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
thanks for all your help @sanposhiho |
Signed-off-by: Kensei Nakada <handbomusic@gmail.com>
Member
Author
|
Thanks @arkodg |
Xunzhuo
approved these changes
May 1, 2025
melsal13
referenced
this pull request
in melsal13/gatewayPersonal
May 7, 2025
* fix: remove sanposhiho from reviewers Signed-off-by: Kensei Nakada <handbomusic@gmail.com> * fix: add sanposhiho to `emeritus-reviewers` Signed-off-by: Kensei Nakada <handbomusic@gmail.com> --------- Signed-off-by: Kensei Nakada <handbomusic@gmail.com> Signed-off-by: melsal13 <mmvsal13@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind documentation
What this PR does / why we need it:
This PR removes me from the reviewer list. I shouldn't even be mentioned in emeritus-reviewers because I haven't done many things here.
My entire OSS work time is very limited (since it's just a hobby), and I actually haven't had enough time working on this project since I've been promoted to the reviewer. (sorry 😢 ) I was hoping I'd get some more time for this project as well after my Europe travel period, but very likely I won't because I've got more responsibilities in kubernetes, which I have/want to prioritize, and have been consuming extra time.
Which issue(s) this PR fixes:
Fixes #
Release Notes: No