fix(translator): Early status push for headless Service#5827
Merged
arkodg merged 16 commits intoenvoyproxy:mainfrom Apr 29, 2025
Merged
fix(translator): Early status push for headless Service#5827arkodg merged 16 commits intoenvoyproxy:mainfrom
arkodg merged 16 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: ShinyaIshitobi <shinya.ishitobi@gmail.com>
Signed-off-by: ShinyaIshitobi <shinya.ishitobi@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5827 +/- ##
==========================================
- Coverage 65.31% 65.30% -0.01%
==========================================
Files 221 221
Lines 35314 35325 +11
==========================================
+ Hits 23064 23069 +5
- Misses 10825 10831 +6
Partials 1425 1425 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: ShinyaIshitobi <shinya.ishitobi@gmail.com>
zirain
previously approved these changes
Apr 27, 2025
Member
|
/retest |
Contributor
Author
|
Thank you for review! |
Signed-off-by: ShinyaIshitobi <shinya.ishitobi@gmail.com>
Signed-off-by: ShinyaIshitobi <shinya.ishitobi@gmail.com>
Signed-off-by: ShinyaIshitobi <shinya.ishitobi@gmail.com>
zirain
force-pushed
the
validate-headless
branch
from
dbdb8a1 to
2a0ecf1
Compare
Contributor
Signed-off-by: ShinyaIshitobi <shinya.ishitobi@gmail.com>
Signed-off-by: ShinyaIshitobi <shinya.ishitobi@gmail.com>
Signed-off-by: ShinyaIshitobi <shinya.ishitobi@gmail.com>
…ateway into validate-headless
Contributor
Author
|
I added two test cases:
|
Signed-off-by: ShinyaIshitobi <shinya.ishitobi@gmail.com>
Signed-off-by: ShinyaIshitobi <shinya.ishitobi@gmail.com>
arkodg
reviewed
Apr 29, 2025
internal/gatewayapi/route.go
Outdated
| case resource.KindService, resource.KindServiceImport: | ||
| if endpointRoutingDisabled && isHeadlessService(destinationSettings) { | ||
| return status.NewRouteStatusError( | ||
| fmt.Errorf("service %s is headless Service, please set routingType=Endpoint", destinationSettings.Name), |
Contributor
There was a problem hiding this comment.
Suggested change
| fmt.Errorf("service %s is headless Service, please set routingType=Endpoint", destinationSettings.Name), | |
| fmt.Errorf("service %s is a headless Service, please set routingType=Endpoint", destinationSettings.Name), |
Signed-off-by: ShinyaIshitobi <shinya.ishitobi@gmail.com>
arkodg
approved these changes
Apr 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
fix(translator): Early status push for headless Service
What this PR does / why we need it:
headless Services early by setting RouteConditionResolvedRefs=False with
reason=UnsupportedSetting, preventing xDS validation failures.
isHeadlessServicehelper.isHeadlessServiceandvalidateDestinationSettings.Which issue(s) this PR fixes:
Fixes #5708
Release Notes: No