docs(grpc): add note on using BackendTrafficPolicy for GPRC timeouts#5822
Merged
arkodg merged 3 commits intoenvoyproxy:mainfrom May 1, 2025
Merged
docs(grpc): add note on using BackendTrafficPolicy for GPRC timeouts#5822arkodg merged 3 commits intoenvoyproxy:mainfrom
BackendTrafficPolicy for GPRC timeouts#5822arkodg merged 3 commits intoenvoyproxy:mainfrom
Conversation
Antvirf
force-pushed
the
docs/grpc-timeouts
branch
from
faa2b46 to
0716678
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5822 +/- ##
==========================================
- Coverage 65.17% 65.15% -0.02%
==========================================
Files 224 224
Lines 35857 35857
==========================================
- Hits 23371 23364 -7
- Misses 11042 11047 +5
- Partials 1444 1446 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Antvirf
force-pushed
the
docs/grpc-timeouts
branch
from
0716678 to
269976d
Compare
arkodg
reviewed
Apr 28, 2025
Contributor
There was a problem hiding this comment.
lint is failing because it can't resolve this link
Signed-off-by: antvirf <antti.viitala@icloud.com>
Antvirf
force-pushed
the
docs/grpc-timeouts
branch
from
2fdff62 to
9f11849
Compare
Contributor
Author
|
Apologies @arkodg , that should now be sorted! Not entirely sure why that happens to be honest, this file in that same directory has |
arkodg
approved these changes
May 1, 2025
shawnh2
approved these changes
May 1, 2025
melsal13
referenced
this pull request
in melsal13/gatewayPersonal
May 7, 2025
…s (#5822) docs(grpc): add note on using for GPRC timeouts Signed-off-by: antvirf <antti.viitala@icloud.com> Signed-off-by: melsal13 <mmvsal13@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Docs update to help people figure out how to configure/disable timeouts for GRPC routes. More discussion here #5768
What this PR does / why we need it:
It's not obvious from the current docs that such an option is available.
Release Notes: No