Skip to content

enhancement: add api-version for load #5816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arkodg merged 3 commits into from
Apr 26, 2025
Merged

enhancement: add api-version for load #5816

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2cb6e70
add reference-grant as supported kind
shawnh2 Apr 25, 2025
71134ae
add apiversion field for each load resources
shawnh2 Apr 25, 2025
9bf5e82
fix test
shawnh2 Apr 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions internal/cmd/egctl/testdata/translate/out/backend-endpoint.all.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
backendTLSPolicies:
- kind: BackendTLSPolicy
- apiVersion: gateway.networking.k8s.io/v1alpha3
kind: BackendTLSPolicy
metadata:
creationTimestamp: null
name: example-com-tls-policy
Expand All @@ -26,7 +27,8 @@ backendTLSPolicies:
type: Accepted
controllerName: gateway.envoyproxy.io/gatewayclass-controller
backends:
- kind: Backend
- apiVersion: gateway.envoyproxy.io/v1alpha1
kind: Backend
metadata:
creationTimestamp: null
name: backend
Expand All @@ -45,7 +47,8 @@ backends:
status: "True"
type: Accepted
envoyExtensionPolicies:
- kind: EnvoyExtensionPolicy
- apiVersion: gateway.envoyproxy.io/v1alpha1
kind: EnvoyExtensionPolicy
metadata:
creationTimestamp: null
name: ext-proc-example
Expand Down Expand Up @@ -82,6 +85,7 @@ envoyExtensionPolicies:
type: Accepted
controllerName: gateway.envoyproxy.io/gatewayclass-controller
gatewayClass:
apiVersion: gateway.networking.k8s.io/v1
kind: GatewayClass
metadata:
creationTimestamp: null
Expand All @@ -96,7 +100,8 @@ gatewayClass:
status: "True"
type: Accepted
gateways:
- kind: Gateway
- apiVersion: gateway.networking.k8s.io/v1
kind: Gateway
metadata:
creationTimestamp: null
name: eg
Expand Down Expand Up @@ -136,7 +141,8 @@ gateways:
- group: gateway.networking.k8s.io
kind: GRPCRoute
httpRoutes:
- kind: HTTPRoute
- apiVersion: gateway.networking.k8s.io/v1
kind: HTTPRoute
metadata:
creationTimestamp: null
name: backend
Expand Down
10 changes: 7 additions & 3 deletions internal/cmd/egctl/testdata/translate/out/default-namespace.all.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
backends:
- kind: Backend
- apiVersion: gateway.envoyproxy.io/v1alpha1
kind: Backend
metadata:
creationTimestamp: null
name: backend
Expand All @@ -18,6 +19,7 @@ backends:
status: "True"
type: Accepted
gatewayClass:
apiVersion: gateway.networking.k8s.io/v1
kind: GatewayClass
metadata:
creationTimestamp: null
Expand All @@ -32,7 +34,8 @@ gatewayClass:
status: "True"
type: Accepted
gateways:
- kind: Gateway
- apiVersion: gateway.networking.k8s.io/v1
kind: Gateway
metadata:
creationTimestamp: null
name: eg
Expand Down Expand Up @@ -72,7 +75,8 @@ gateways:
- group: gateway.networking.k8s.io
kind: GRPCRoute
httpRoutes:
- kind: HTTPRoute
- apiVersion: gateway.networking.k8s.io/v1
kind: HTTPRoute
metadata:
creationTimestamp: null
name: backend
Expand Down
21 changes: 15 additions & 6 deletions internal/cmd/egctl/testdata/translate/out/default-resources.all.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
envoyProxyForGatewayClass:
apiVersion: gateway.envoyproxy.io/v1alpha1
kind: EnvoyProxy
metadata:
creationTimestamp: null
name: default-envoy-proxy
Expand Down Expand Up @@ -176,6 +178,7 @@ envoyProxyForGatewayClass:
logging: {}
status: {}
gatewayClass:
apiVersion: gateway.networking.k8s.io/v1
kind: GatewayClass
metadata:
creationTimestamp: null
Expand All @@ -195,7 +198,8 @@ gatewayClass:
status: "True"
type: Accepted
gateways:
- kind: Gateway
- apiVersion: gateway.networking.k8s.io/v1
kind: Gateway
metadata:
creationTimestamp: null
name: eg
Expand Down Expand Up @@ -350,7 +354,8 @@ gateways:
- group: gateway.networking.k8s.io
kind: GRPCRoute
grpcRoutes:
- kind: GRPCRoute
- apiVersion: gateway.networking.k8s.io/v1
kind: GRPCRoute
metadata:
creationTimestamp: null
name: backend
Expand Down Expand Up @@ -395,7 +400,8 @@ grpcRoutes:
name: eg
sectionName: grpc
httpRoutes:
- kind: HTTPRoute
- apiVersion: gateway.networking.k8s.io/v1
kind: HTTPRoute
metadata:
creationTimestamp: null
name: backend
Expand Down Expand Up @@ -437,7 +443,8 @@ httpRoutes:
kind: Gateway
name: eg
tcpRoutes:
- kind: TCPRoute
- apiVersion: gateway.networking.k8s.io/v1alpha2
kind: TCPRoute
metadata:
creationTimestamp: null
name: backend
Expand Down Expand Up @@ -475,7 +482,8 @@ tcpRoutes:
name: eg
sectionName: tcp
tlsRoutes:
- kind: TLSRoute
- apiVersion: gateway.networking.k8s.io/v1alpha2
kind: TLSRoute
metadata:
creationTimestamp: null
name: backend
Expand Down Expand Up @@ -513,7 +521,8 @@ tlsRoutes:
name: eg
sectionName: tls-passthrough
udpRoutes:
- kind: UDPRoute
- apiVersion: gateway.networking.k8s.io/v1alpha2
kind: UDPRoute
metadata:
creationTimestamp: null
name: backend
Expand Down
7 changes: 5 additions & 2 deletions internal/cmd/egctl/testdata/translate/out/echo-gateway-api.cluster.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
gatewayClass:
apiVersion: gateway.networking.k8s.io/v1
kind: GatewayClass
metadata:
creationTimestamp: null
Expand All @@ -13,7 +14,8 @@ gatewayClass:
status: "True"
type: Accepted
gateways:
- kind: Gateway
- apiVersion: gateway.networking.k8s.io/v1
kind: Gateway
metadata:
creationTimestamp: null
name: eg
Expand Down Expand Up @@ -53,7 +55,8 @@ gateways:
- group: gateway.networking.k8s.io
kind: GRPCRoute
httpRoutes:
- kind: HTTPRoute
- apiVersion: gateway.networking.k8s.io/v1
kind: HTTPRoute
metadata:
creationTimestamp: null
name: backend
Expand Down
3 changes: 3 additions & 0 deletions internal/cmd/egctl/testdata/translate/out/echo-gateway-api.route.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{
"gatewayClass": {
"kind": "GatewayClass",
"apiVersion": "gateway.networking.k8s.io/v1",
"metadata": {
"name": "eg",
"creationTimestamp": null
Expand All @@ -23,6 +24,7 @@
"gateways": [
{
"kind": "Gateway",
"apiVersion": "gateway.networking.k8s.io/v1",
"metadata": {
"name": "eg",
"namespace": "envoy-gateway-system",
Expand Down Expand Up @@ -89,6 +91,7 @@
"httpRoutes": [
{
"kind": "HTTPRoute",
"apiVersion": "gateway.networking.k8s.io/v1",
"metadata": {
"name": "backend",
"namespace": "envoy-gateway-system",
Expand Down
20 changes: 14 additions & 6 deletions internal/cmd/egctl/testdata/translate/out/invalid-envoyproxy.all.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
envoyProxyForGatewayClass:
apiVersion: gateway.envoyproxy.io/v1alpha1
kind: EnvoyProxy
metadata:
creationTimestamp: null
Expand All @@ -23,6 +24,7 @@ envoyProxyForGatewayClass:
default: warn
status: {}
gatewayClass:
apiVersion: gateway.networking.k8s.io/v1
kind: GatewayClass
metadata:
creationTimestamp: null
Expand All @@ -42,7 +44,8 @@ gatewayClass:
status: "False"
type: Accepted
gateways:
- kind: Gateway
- apiVersion: gateway.networking.k8s.io/v1
kind: Gateway
metadata:
creationTimestamp: null
name: eg
Expand Down Expand Up @@ -197,7 +200,8 @@ gateways:
- group: gateway.networking.k8s.io
kind: GRPCRoute
grpcRoutes:
- kind: GRPCRoute
- apiVersion: gateway.networking.k8s.io/v1
kind: GRPCRoute
metadata:
creationTimestamp: null
name: backend
Expand Down Expand Up @@ -242,7 +246,8 @@ grpcRoutes:
name: eg
sectionName: grpc
httpRoutes:
- kind: HTTPRoute
- apiVersion: gateway.networking.k8s.io/v1
kind: HTTPRoute
metadata:
creationTimestamp: null
name: backend
Expand Down Expand Up @@ -284,7 +289,8 @@ httpRoutes:
kind: Gateway
name: eg
tcpRoutes:
- kind: TCPRoute
- apiVersion: gateway.networking.k8s.io/v1alpha2
kind: TCPRoute
metadata:
creationTimestamp: null
name: backend
Expand Down Expand Up @@ -322,7 +328,8 @@ tcpRoutes:
name: eg
sectionName: tcp
tlsRoutes:
- kind: TLSRoute
- apiVersion: gateway.networking.k8s.io/v1alpha2
kind: TLSRoute
metadata:
creationTimestamp: null
name: backend
Expand Down Expand Up @@ -360,7 +367,8 @@ tlsRoutes:
name: eg
sectionName: tls-passthrough
udpRoutes:
- kind: UDPRoute
- apiVersion: gateway.networking.k8s.io/v1alpha2
kind: UDPRoute
metadata:
creationTimestamp: null
name: backend
Expand Down
6 changes: 4 additions & 2 deletions internal/cmd/egctl/testdata/translate/out/quickstart.all.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
gateways:
- kind: Gateway
- apiVersion: gateway.networking.k8s.io/v1
kind: Gateway
metadata:
creationTimestamp: null
name: eg
Expand Down Expand Up @@ -39,7 +40,8 @@ gateways:
- group: gateway.networking.k8s.io
kind: GRPCRoute
httpRoutes:
- kind: HTTPRoute
- apiVersion: gateway.networking.k8s.io/v1
kind: HTTPRoute
metadata:
creationTimestamp: null
name: backend
Expand Down
7 changes: 5 additions & 2 deletions internal/cmd/egctl/testdata/translate/out/rejected-http-route.route.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
gatewayClass:
apiVersion: gateway.networking.k8s.io/v1
kind: GatewayClass
metadata:
creationTimestamp: null
Expand All @@ -13,7 +14,8 @@ gatewayClass:
status: "True"
type: Accepted
gateways:
- kind: Gateway
- apiVersion: gateway.networking.k8s.io/v1
kind: Gateway
metadata:
creationTimestamp: null
name: eg
Expand Down Expand Up @@ -48,7 +50,8 @@ gateways:
- group: gateway.networking.k8s.io
kind: TLSRoute
httpRoutes:
- kind: HTTPRoute
- apiVersion: gateway.networking.k8s.io/v1
kind: HTTPRoute
metadata:
creationTimestamp: null
name: backend
Expand Down
Loading