Skip to content

fix: ext auth example used a deprecated interface#5771

Merged
arkodg merged 1 commit intoenvoyproxy:mainfrom
pkit:fix_ext_auth_dep
Apr 24, 2025
Merged

fix: ext auth example used a deprecated interface#5771
arkodg merged 1 commit intoenvoyproxy:mainfrom
pkit:fix_ext_auth_dep

Conversation

@pkit
Copy link
Contributor

@pkit pkit commented Apr 19, 2025

What type of PR is this?

examples: fix deprecated interface

Release Notes: No

@pkit pkit requested a review from a team as a code owner April 19, 2025 18:31
@pkit pkit force-pushed the fix_ext_auth_dep branch from bee00ac to 026c28e Compare April 19, 2025 18:33
zhaohuabing
zhaohuabing previously approved these changes Apr 21, 2025
@codecov
Copy link

codecov bot commented Apr 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.42%. Comparing base (096cb8d) to head (0291822).
Report is 34 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5771      +/-   ##
==========================================
+ Coverage   65.19%   65.42%   +0.22%     
==========================================
  Files         214      215       +1     
  Lines       34321    34608     +287     
==========================================
+ Hits        22377    22641     +264     
- Misses      10591    10592       +1     
- Partials     1353     1375      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

arkodg
arkodg previously approved these changes Apr 21, 2025
@arkodg
Copy link
Contributor

arkodg commented Apr 21, 2025

seeing a lint error

150:1 syntax error: found character '\t' that cannot start any token (syntax)

@pkit pkit dismissed stale reviews from arkodg and zhaohuabing via 26010e3 April 21, 2025 19:17
@pkit pkit force-pushed the fix_ext_auth_dep branch from 026c28e to 26010e3 Compare April 21, 2025 19:17
@pkit
Copy link
Contributor Author

pkit commented Apr 21, 2025

seeing a lint error

150:1 syntax error: found character '\t' that cannot start any token (syntax)

9 spaces and then tabs? Lol.
Fixed.

arkodg
arkodg previously approved these changes Apr 21, 2025
@zirain
Copy link
Member

zirain commented Apr 21, 2025

./examples/kubernetes/ext-auth-grpc-service.yaml
  Error: 150:9 syntax error: found character '\t' that cannot start any token (syntax)

examples/kubernetes/ext-auth-grpc-service.yaml
  Error: 150:9 syntax error: found character '\t' that cannot start any token (syntax)

Signed-off-by: Constantine Peresypkin <pconstantine@gmail.com>
@pkit
Copy link
Contributor Author

pkit commented Apr 21, 2025

Omg. It was the last space.
It's too much involvement for a one line fix. And all because yamllint has no auto-fix

@arkodg arkodg merged commit d852852 into envoyproxy:main Apr 24, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants