Skip to content

chore: go fumpt the code#5742

Merged
shawnh2 merged 1 commit intoenvoyproxy:mainfrom
cnvergence:chore-git-fumpt
Apr 16, 2025
Merged

chore: go fumpt the code#5742
shawnh2 merged 1 commit intoenvoyproxy:mainfrom
cnvergence:chore-git-fumpt

Conversation

@cnvergence
Copy link
Member

What type of PR is this?

What this PR does / why we need it:

Running go fumpt across the latest codebase.

Release Notes: No

Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
@cnvergence cnvergence requested a review from a team as a code owner April 16, 2025 10:22
@codecov
Copy link

codecov bot commented Apr 16, 2025

Codecov Report

Attention: Patch coverage is 69.23077% with 8 lines in your changes missing coverage. Please review.

Project coverage is 65.20%. Comparing base (096cb8d) to head (c5da67d).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
internal/cmd/egctl/stats_envoy.go 0.00% 3 Missing ⚠️
internal/cmd/envoy/shutdown_manager.go 0.00% 1 Missing ⚠️
internal/kubernetes/client.go 0.00% 1 Missing ⚠️
internal/provider/kubernetes/secrets.go 0.00% 1 Missing ⚠️
internal/troubleshoot/collect.go 0.00% 1 Missing ⚠️
...ternal/troubleshoot/collect/troubleshoot_helper.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5742   +/-   ##
=======================================
  Coverage   65.19%   65.20%           
=======================================
  Files         214      214           
  Lines       34321    34321           
=======================================
+ Hits        22377    22379    +2     
+ Misses      10591    10589    -2     
  Partials     1353     1353           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@shawnh2 shawnh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Is there any chance we can enable gofumpt for the CI ?

@cnvergence
Copy link
Member Author

I can check that, I know that the linter checks for that on the new changes

@shawnh2 shawnh2 merged commit 4e0f353 into envoyproxy:main Apr 16, 2025
24 of 25 checks passed
@cnvergence cnvergence deleted the chore-git-fumpt branch April 16, 2025 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants