feat(helm): Add management of extensionApis#5741
Merged
arkodg merged 1 commit intoenvoyproxy:mainfrom Apr 18, 2025
Merged
Conversation
sorrison
force-pushed
the
helm-extensionapi
branch
from
3c49e48 to
1f02aa9
Compare
arkodg
reviewed
Apr 16, 2025
charts/gateway-helm/values.tmpl.yaml
Outdated
Contributor
There was a problem hiding this comment.
can this be added in L97 instead ? under config.envoyGateway ?
Contributor
Author
There was a problem hiding this comment.
ok I've done that but I think it has unintended consequences. At least when I added all the stuff from make generate but still learning all this stuff
Signed-off-by: Sam Morrison <sorrison@gmail.com>
sorrison
force-pushed
the
helm-extensionapi
branch
from
1f02aa9 to
d53114f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5741 +/- ##
==========================================
- Coverage 65.19% 65.18% -0.02%
==========================================
Files 214 214
Lines 34321 34444 +123
==========================================
+ Hits 22377 22451 +74
- Misses 10591 10629 +38
- Partials 1353 1364 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zirain
approved these changes
Apr 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds the ability to enable extension APIs with the helm chart