fix: return err if direct response size exceeds limit#5710
Merged
arkodg merged 3 commits intoenvoyproxy:mainfrom Apr 11, 2025
Merged
fix: return err if direct response size exceeds limit#5710arkodg merged 3 commits intoenvoyproxy:mainfrom
arkodg merged 3 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5710 +/- ##
==========================================
+ Coverage 65.28% 65.31% +0.02%
==========================================
Files 213 213
Lines 34111 34121 +10
==========================================
+ Hits 22270 22285 +15
+ Misses 10500 10499 -1
+ Partials 1341 1337 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zirain
previously approved these changes
Apr 11, 2025
zhaohuabing
previously approved these changes
Apr 11, 2025
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
zhaohuabing
approved these changes
Apr 11, 2025
zirain
reviewed
Apr 11, 2025
zirain
approved these changes
Apr 11, 2025
guydc
pushed a commit
to guydc/gateway
that referenced
this pull request
May 8, 2025
* fix: return err if direct response size exceeds limit Signed-off-by: Arko Dasgupta <arko@tetrate.io> * lint Signed-off-by: Arko Dasgupta <arko@tetrate.io> * add another check Signed-off-by: Arko Dasgupta <arko@tetrate.io> --------- Signed-off-by: Arko Dasgupta <arko@tetrate.io> (cherry picked from commit 3ebf245) Signed-off-by: Guy Daich <guy.daich@sap.com>
guydc
added a commit
that referenced
this pull request
May 8, 2025
* fix: return err if direct response size exceeds limit (#5710) * fix: return err if direct response size exceeds limit Signed-off-by: Arko Dasgupta <arko@tetrate.io> * lint Signed-off-by: Arko Dasgupta <arko@tetrate.io> * add another check Signed-off-by: Arko Dasgupta <arko@tetrate.io> --------- Signed-off-by: Arko Dasgupta <arko@tetrate.io> (cherry picked from commit 3ebf245) Signed-off-by: Guy Daich <guy.daich@sap.com> * fix: httproute precedence by considering header/query match type (#5740) * fix precedence to use number of exact matches Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com> (cherry picked from commit b295b09) Signed-off-by: Guy Daich <guy.daich@sap.com> * fix: SecurityPolicy reference grant (#5792) * fix: SecurityPolicy reference grant Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com> * add: release note Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com> * update: func name Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com> * revert func name Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com> * update: use processBackendRef to handle route backends Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com> * fix: use not pointer type for extAuth backendRef Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com> * Add: testcase for ExtAuth Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com> * fix: add jwt backendref to backendSecurityPolicyIndexFunc Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com> --------- Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com> (cherry picked from commit ef50718) Signed-off-by: Guy Daich <guy.daich@sap.com> * fix: add validation for header values (#5933) Signed-off-by: Gavin Lam <gavin.oss@tutamail.com> (cherry picked from commit 5e7df65) Signed-off-by: Guy Daich <guy.daich@sap.com> * fix: Fixed typo in error message. (#5945) Signed-off-by: Mathias Westby Skoglund <mail@mathiaswskoglund.com> Co-authored-by: Mathias Westby Skoglund <mail@mathiaswskoglund.com> (cherry picked from commit 2bbbdf8) Signed-off-by: Guy Daich <guy.daich@sap.com> * fix gen Signed-off-by: Guy Daich <guy.daich@sap.com> * merge fixes Signed-off-by: Guy Daich <guy.daich@sap.com> * fix: process remaining gatewayClasses after encountering an err (#5953) fix: process all gatewayClasses after encountering an err * instead of returning from Reconcile after encountering an err which processing a `GatewayClass`, `continue` instead to process all GatewayClasses Fixes: #5618 Signed-off-by: Arko Dasgupta <arko@tetrate.io> (cherry picked from commit 64845fe) Signed-off-by: Guy Daich <guy.daich@sap.com> * fix: do not add tls inspector filter to quic listener (#5671) * fix: enable http3 but panic Signed-off-by: bitliu <bitliu@tencent.com> (cherry picked from commit 46e053b) Signed-off-by: Guy Daich <guy.daich@sap.com> * notes Signed-off-by: Guy Daich <guy.daich@sap.com> --------- Signed-off-by: Arko Dasgupta <arko@tetrate.io> Signed-off-by: Guy Daich <guy.daich@sap.com> Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com> Signed-off-by: Gavin Lam <gavin.oss@tutamail.com> Signed-off-by: Mathias Westby Skoglund <mail@mathiaswskoglund.com> Signed-off-by: bitliu <bitliu@tencent.com> Co-authored-by: Arko Dasgupta <arkodg@users.noreply.github.com> Co-authored-by: Kota Kimura <86363983+kkk777-7@users.noreply.github.com> Co-authored-by: Gavin Lam <gavin.oss@tutamail.com> Co-authored-by: Mathias Westby Skoglund <71329699+mathias-ws@users.noreply.github.com> Co-authored-by: Mathias Westby Skoglund <mail@mathiaswskoglund.com> Co-authored-by: Xunzhuo <bitliu@tencent.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.