fix: invalid basic auth data caused rds rejection

[Xunzhuo]

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #5581

Release Notes: Yes/No

[arkodg]

I dont understand the fix here @Xunzhuo
the issue is that the file passed down to envoy was invalid, causing envoy to reject RDS

the fix here is to validate the basic auth data

gateway/internal/gatewayapi/securitypolicy.go

Line 1176 in 2bbbdf8

usersSecretBytes, ok := usersSecret.Data[egv1a1.BasicAuthUsersSecretKey]

[codecov]

Codecov Report

Attention: Patch coverage is 77.77778% with 6 lines in your changes missing coverage. Please review.

Project coverage is 70.72%. Comparing base (16747d4) to head (0783e2b).
Report is 4 commits behind head on main.

Files with missing lines	Patch %	Lines
internal/gatewayapi/securitypolicy.go	77.77%	4 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5683      +/-   ##
==========================================
- Coverage   70.76%   70.72%   -0.05%     
==========================================
  Files         220      220              
  Lines       37059    37086      +27     
==========================================
+ Hits        26225    26229       +4     
- Misses       9299     9318      +19     
- Partials     1535     1539       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Xunzhuo]

@arkodg get it, plz help review it : )

[github-actions]

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions!

[arkodg]

LGTM thanks !

can you rebase again ( 🙈 )

[shawnh2]

LGTM!