benchmark: more accurate metrics and profiles#5580
Merged
arkodg merged 5 commits intoenvoyproxy:mainfrom Mar 25, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5580 +/- ##
==========================================
+ Coverage 65.23% 65.25% +0.02%
==========================================
Files 213 213
Lines 34069 34073 +4
==========================================
+ Hits 22224 22235 +11
+ Misses 10508 10504 -4
+ Partials 1337 1334 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
5930afd to
de62195
Compare
Contributor
Author
|
Before:
After:
|
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
fe03770 to
36114e8
Compare
arkodg
reviewed
Mar 25, 2025
arkodg
previously approved these changes
Mar 25, 2025
Co-authored-by: Arko Dasgupta <arkodg@users.noreply.github.com> Signed-off-by: sh2 <shawnhxh@outlook.com>
zirain
approved these changes
Mar 25, 2025
arkodg
approved these changes
Mar 25, 2025
lxie123
pushed a commit
to lxie123/gateway
that referenced
this pull request
Mar 26, 2025
* sample prom metrics and pprof profiles Signed-off-by: shawnh2 <shawnhxh@outlook.com> * update env table data and promql Signed-off-by: shawnh2 <shawnhxh@outlook.com> * enhance metrics value process Signed-off-by: shawnh2 <shawnhxh@outlook.com> * optimze report Signed-off-by: shawnh2 <shawnhxh@outlook.com> * update typo in suite.go Co-authored-by: Arko Dasgupta <arkodg@users.noreply.github.com> Signed-off-by: sh2 <shawnhxh@outlook.com> --------- Signed-off-by: shawnh2 <shawnhxh@outlook.com> Signed-off-by: sh2 <shawnhxh@outlook.com> Co-authored-by: Arko Dasgupta <arkodg@users.noreply.github.com> Signed-off-by: Ubuntu <lxie@k0rdent.dg30utm4mk2e3fblffod03krea.bx.internal.cloudapp.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
We used to collect metrics and profiles at the end of one benchmark test, the result may not be accurate, becasue the metrics like
process_resident_memory_bytesandcontainer_memory_working_set_bytesare instant value, they only reflect the status at the time of our promql request, same as pprof profiles.process_cpu_seconds_totalandcontainer_cpu_usage_seconds_totalare cumulative value, we should userate()to get its value during a time rangeSo this PR samples metrics and profiles at test runtime, and report the min/max/mean of mem and cpu during the test run (ditto for pprof profiles), in order to make the benchmark result more accurate and trustworthy.
Which issue(s) this PR fixes:
ref: #4516, #4498
Release Notes: No