Skip to content

Secret validation error in TLS termination mode with Envoy Gateway Standalone #5575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arkodg merged 7 commits into from
Mar 28, 2025
Merged

Secret validation error in TLS termination mode with Envoy Gateway Standalone #5575

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b83082b
set secret type
arminabf Mar 21, 2025
1a6ffad
add new test case for Secret with type
arminabf Mar 24, 2025
06a8b43
use generated output
arminabf Mar 24, 2025
55fdba7
Merge branch 'main' into listener-https-terminate-secret-type
arminabf Mar 24, 2025
ec05f63
combine getting typed secret type
arminabf Mar 25, 2025
6f3717e
Merge branch 'main' into listener-https-terminate-secret-type
arminabf Mar 25, 2025
1620e63
Merge branch 'main' into listener-https-terminate-secret-type
arminabf Mar 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions internal/gatewayapi/resource/load.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,6 +315,9 @@ func loadKubernetesYAMLToResources(input []byte, addMissingResources bool) (*Res
case KindSecret:
typedData := data.Interface()
typedStringData := stringData.Interface()
secretType := kobjVal.FieldByName("Type")
typedSecretType := secretType.Interface()
Comment thread
arminabf marked this conversation as resolved.
Outdated

secret := &corev1.Secret{
TypeMeta: metav1.TypeMeta{
Kind: KindSecret,
Expand All @@ -323,6 +326,7 @@ func loadKubernetesYAMLToResources(input []byte, addMissingResources bool) (*Res
Name: name,
Namespace: namespace,
},
Type: typedSecretType.(corev1.SecretType),
Data: typedData.(map[string][]byte),
StringData: typedStringData.(map[string]string),
}
Expand Down
9 changes: 9 additions & 0 deletions internal/gatewayapi/resource/testdata/all-resources.in.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,6 +257,15 @@ stringData:
secret: "literal value"
---
apiVersion: v1
kind: Secret
metadata:
name: secret-with-type
namespace: default
type: "type value"
data:
.secret-file: dmFsdWUtMg0KDQo=
---
apiVersion: v1
kind: ConfigMap
metadata:
name: configmap
Expand Down
8 changes: 8 additions & 0 deletions internal/gatewayapi/resource/testdata/all-resources.out.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,6 +270,14 @@ secrets:
namespace: default
stringData:
secret: literal value
- data:
.secret-file: dmFsdWUtMg0KDQo=
kind: Secret
metadata:
creationTimestamp: null
name: secret-with-type
namespace: default
type: type value
securityPolicies:
- kind: SecurityPolicy
metadata:
Expand Down