Skip to content

fix: dont return an err when gatewayclass is not accepted#5524

Merged
zirain merged 2 commits intoenvoyproxy:mainfrom
arkodg:no-error-bad-gwc-status
Mar 18, 2025
Merged

fix: dont return an err when gatewayclass is not accepted#5524
zirain merged 2 commits intoenvoyproxy:mainfrom
arkodg:no-error-bad-gwc-status

Conversation

@arkodg
Copy link
Contributor

@arkodg arkodg commented Mar 17, 2025

this is a user generated error, we shouldnt log it as a system error, and return with an error

@arkodg arkodg requested a review from a team as a code owner March 17, 2025 19:30
@arkodg arkodg changed the title bug: dont return an err when gatewayclass is not accepted fix: dont return an err when gatewayclass is not accepted Mar 17, 2025
@codecov
Copy link

codecov bot commented Mar 17, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 65.19%. Comparing base (260b3f6) to head (d645767).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/provider/kubernetes/controller.go 0.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (60.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5524      +/-   ##
==========================================
- Coverage   65.20%   65.19%   -0.01%     
==========================================
  Files         213      213              
  Lines       34033    34032       -1     
==========================================
- Hits        22190    22188       -2     
- Misses      10515    10516       +1     
  Partials     1328     1328

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Arko Dasgupta added 2 commits March 18, 2025 19:08
@zirain
bug: dont return an err when gatewayclass is not accepted
2c914fe 
this is a user generated error, we shouldnt log it as
a system error, and return with an error

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@zirain
release notes
d645767 
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@zirain zirain force-pushed the no-error-bad-gwc-status branch from 81ef606 to d645767 Compare March 18, 2025 11:08
@zirain zirain merged commit 51e87ca into envoyproxy:main Mar 18, 2025
24 of 25 checks passed
guydc pushed a commit to guydc/gateway that referenced this pull request Mar 21, 2025
@arkodg @guydc
fix: dont return an err when gatewayclass is not accepted (envoyproxy…
888e0fd 
…#5524)

* bug: dont return an err when gatewayclass is not accepted

this is a user generated error, we shouldnt log it as
a system error, and return with an error

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* release notes

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

---------

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
(cherry picked from commit 51e87ca)
Signed-off-by: Guy Daich <guy.daich@sap.com>
zhaohuabing pushed a commit to zhaohuabing/gateway that referenced this pull request Mar 22, 2025
@arkodg @zhaohuabing
fix: dont return an err when gatewayclass is not accepted (envoyproxy…
952ce65 
…#5524)

* bug: dont return an err when gatewayclass is not accepted

this is a user generated error, we shouldnt log it as
a system error, and return with an error

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* release notes

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

---------

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
(cherry picked from commit 51e87ca)
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
guydc added a commit that referenced this pull request Mar 24, 2025
@guydc @arkodg
@zhaohuabing @mathetake @markwinter @nareddyt @kraashen
[release/v1.3] Release v1.3.2 cherry-pick (#5576)
1e9f2a3 
* load BackendTLSPolicy in standalone mode (#5431)

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
(cherry picked from commit 4d914ae)
Signed-off-by: Guy Daich <guy.daich@sap.com>

* Wasm: cache Wasm OCI image permission check results (#5358)

* add TTL for wasm permission check

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>

* fix test

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>

* change

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>

* refresh the cache

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>

* purge the cache

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>

* refactor

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>

* on retry on retriable errors

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>

* add release note

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>

---------

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
(cherry picked from commit 672de8a)
Signed-off-by: Guy Daich <guy.daich@sap.com>

* Load EnvoyExtensionPolicy in standalone mode (#5460)

* load EnvoyExtensionPolicy in standalone mode

Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>

* more

Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>

* release note

Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>

* review: use a valid target name instead of myapp

Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>

* gen

Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>

---------

Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
(cherry picked from commit 4be098d)
Signed-off-by: Guy Daich <guy.daich@sap.com>

* fix: check for mirror backendRef in httproute index (#5497)

* check for mirror backendRef

Signed-off-by: mark winter <mark.winter@thetradedesk.com>
(cherry picked from commit 72b72c4)
Signed-off-by: Guy Daich <guy.daich@sap.com>

* fix: dont return an err when gatewayclass is not accepted (#5524)

* bug: dont return an err when gatewayclass is not accepted

this is a user generated error, we shouldnt log it as
a system error, and return with an error

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* release notes

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

---------

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
(cherry picked from commit 51e87ca)
Signed-off-by: Guy Daich <guy.daich@sap.com>

* fix: host header should not be allowed to modify (#5533)

* host header is not allowed to be modified

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>

* address comment

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>

---------

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
(cherry picked from commit 54efa34)
Signed-off-by: Guy Daich <guy.daich@sap.com>

* fix: retrigger reconciliation when backendRef of type ServiceImport is updated (#5461)

* fix: retrigger reconilation when backendRef of type ServiceImport is updated

Signed-off-by: Teju Nareddy <tejunareddy@gmail.com>
(cherry picked from commit e2f8978)
Signed-off-by: Guy Daich <guy.daich@sap.com>

* pin envoy and ratelimit

Signed-off-by: Guy Daich <guy.daich@sap.com>

* fix: otel sink json access logging without text field (#5498)

* fix otel sink json access logging without text field

Signed-off-by: Tomi Juntunen <tomi.juntunen@iki.fi>

* use json format as default when format or type is not set

Signed-off-by: Tomi Juntunen <tomi.juntunen@iki.fi>

* set formatters only if the slice of formatters is not empty

Signed-off-by: Tomi Juntunen <tomi.juntunen@iki.fi>

---------

Signed-off-by: Tomi Juntunen <tomi.juntunen@iki.fi>
Co-authored-by: Arko Dasgupta <arkodg@users.noreply.github.com>
(cherry picked from commit cb3ffd2)
Signed-off-by: Guy Daich <guy.daich@sap.com>

* [release/v1.3] v1.3.2 release notes (#5584)

v1.3.2 release notes

Signed-off-by: Guy Daich <guy.daich@sap.com>

---------

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Guy Daich <guy.daich@sap.com>
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
Signed-off-by: mark winter <mark.winter@thetradedesk.com>
Signed-off-by: Teju Nareddy <tejunareddy@gmail.com>
Signed-off-by: Tomi Juntunen <tomi.juntunen@iki.fi>
Co-authored-by: Arko Dasgupta <arkodg@users.noreply.github.com>
Co-authored-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
Co-authored-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
Co-authored-by: Mark Winter <wintermarkedward@gmail.com>
Co-authored-by: Teju Nareddy <tejunareddy@gmail.com>
Co-authored-by: Tomi Juntunen <tomi.juntunen@iki.fi>
arkodg added a commit that referenced this pull request Mar 25, 2025
@zhaohuabing @arkodg
@markwinter @mathetake @kraashen
[release/v1.2.8] cherry pick (#5566)
5ccc8ad 
* bump envoy to v1.32.4

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>

* fix: host header should not be allowed to modify (#5533)

* host header is not allowed to be modified

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>

* address comment

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>

---------

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
(cherry picked from commit 54efa34)
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>

* add release note

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>

* bump ratelimit to 0141a24

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>

* Wasm: cache Wasm OCI image permission check results (#5358)

* add TTL for wasm permission check

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>

* fix test

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>

* change

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>

* refresh the cache

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>

* purge the cache

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>

* refactor

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>

* on retry on retriable errors

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>

* add release note

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>

---------

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
(cherry picked from commit 672de8a)
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>

* load BackendTLSPolicy in standalone mode (#5431)

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
(cherry picked from commit 4d914ae)
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>

* fix: check for mirror backendRef in httproute index (#5497)

* check for mirror backendRef

Signed-off-by: mark winter <mark.winter@thetradedesk.com>
(cherry picked from commit 72b72c4)
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>

* fix: dont return an err when gatewayclass is not accepted (#5524)

* bug: dont return an err when gatewayclass is not accepted

this is a user generated error, we shouldnt log it as
a system error, and return with an error

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* release notes

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

---------

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
(cherry picked from commit 51e87ca)
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>

* update release note

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>

* update reatelimit

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>

* fix gen

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>

* Load EnvoyExtensionPolicy in standalone mode (#5460)

* load EnvoyExtensionPolicy in standalone mode

Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>

* more

Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>

* release note

Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>

* review: use a valid target name instead of myapp

Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>

* gen

Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>

---------

Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
(cherry picked from commit 4be098d)
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>

* add security update to release note

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>

* fix: otel sink json access logging without text field (#5498)

* fix otel sink json access logging without text field

Signed-off-by: Tomi Juntunen <tomi.juntunen@iki.fi>

* use json format as default when format or type is not set

Signed-off-by: Tomi Juntunen <tomi.juntunen@iki.fi>

* set formatters only if the slice of formatters is not empty

Signed-off-by: Tomi Juntunen <tomi.juntunen@iki.fi>

---------

Signed-off-by: Tomi Juntunen <tomi.juntunen@iki.fi>
Co-authored-by: Arko Dasgupta <arkodg@users.noreply.github.com>
(cherry picked from commit cb3ffd2)
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>

* update release date

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>

* update release date

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>

---------

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: mark winter <mark.winter@thetradedesk.com>
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
Signed-off-by: Tomi Juntunen <tomi.juntunen@iki.fi>
Co-authored-by: Arko Dasgupta <arkodg@users.noreply.github.com>
Co-authored-by: Mark Winter <wintermarkedward@gmail.com>
Co-authored-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
Co-authored-by: Tomi Juntunen <tomi.juntunen@iki.fi>
@arkodg arkodg mentioned this pull request Mar 26, 2025
Closed
@arkodg arkodg deleted the no-error-bad-gwc-status branch March 26, 2025 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zirain zirain zirain approved these changes

@rudrakhp rudrakhp rudrakhp approved these changes

@shawnh2 shawnh2 shawnh2 approved these changes

+1 more reviewer

@mathetake mathetake mathetake approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cherrypick/release-v1.2.8 cherrypick/release-v1.3.2 kind/bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@arkodg @zirain @mathetake @rudrakhp @shawnh2