Skip to content

fix: check for mirror backendRef in httproute index #5497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arkodg merged 3 commits into from
Mar 15, 2025
Merged

fix: check for mirror backendRef in httproute index #5497

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
323769f
check for mirror backendRef
markwinter Mar 14, 2025
0234ce2
add endpointslice reconcile test
markwinter Mar 14, 2025
e7f5167
add missing parameter
markwinter Mar 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions internal/provider/kubernetes/indexers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,22 @@ func backendHTTPRouteIndexFunc(rawObj client.Object) []string {
)
}
}

// Check for a RequestMirror filter to also include the backendRef from that filter
for _, filter := range rule.Filters {
if filter.Type != gwapiv1.HTTPRouteFilterRequestMirror {
continue
}

mirrorBackendRef := filter.RequestMirror.BackendRef

backendRefs = append(backendRefs,
types.NamespacedName{
Namespace: gatewayapi.NamespaceDerefOr(mirrorBackendRef.Namespace, httproute.Namespace),
Name: string(mirrorBackendRef.Name),
}.String(),
)
}
}
return backendRefs
}
Expand Down
46 changes: 46 additions & 0 deletions internal/provider/kubernetes/predicates_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,6 +463,52 @@ func TestValidateEndpointSliceForReconcile(t *testing.T) {
endpointSlice: test.GetEndpointSlice(types.NamespacedName{Name: "endpointslice"}, "imported-service", true),
expect: true,
},
{
name: "mirrored backend route exists",
configs: []client.Object{
test.GetGatewayClass("test-gc", egv1a1.GatewayControllerName, nil),
sampleGateway,
&gwapiv1.HTTPRoute{
ObjectMeta: metav1.ObjectMeta{
Name: "httproute-test",
},
Spec: gwapiv1.HTTPRouteSpec{
CommonRouteSpec: gwapiv1.CommonRouteSpec{
ParentRefs: []gwapiv1.ParentReference{
{Name: gwapiv1.ObjectName("scheduled-status-test")},
},
},
Rules: []gwapiv1.HTTPRouteRule{
{
BackendRefs: []gwapiv1.HTTPBackendRef{
{
BackendRef: gwapiv1.BackendRef{
BackendObjectReference: gwapiv1.BackendObjectReference{
Name: gwapiv1.ObjectName("service"),
Port: ptr.To(gwapiv1.PortNumber(80)),
},
},
},
},
Filters: []gwapiv1.HTTPRouteFilter{
{
Type: gwapiv1.HTTPRouteFilterRequestMirror,
RequestMirror: &gwapiv1.HTTPRequestMirrorFilter{
BackendRef: gwapiv1.BackendObjectReference{
Name: "mirror-service",
Port: ptr.To(gwapiv1.PortNumber(80)),
},
},
},
},
},
},
},
},
},
endpointSlice: test.GetEndpointSlice(types.NamespacedName{Name: "endpointslice"}, "mirror-service", false),
expect: true,
},
}

// Create the reconciler.
Expand Down