-
Notifications
You must be signed in to change notification settings - Fork 596
test: add fuzzers for egctl.translateGatewayAPIToIR
#5430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
egctl. translateGatewayAPIToIR
egctl. translateGatewayAPIToIRegctl.translateGatewayAPIToIR
|
@sudiptob2 you'll need to run
|
f8039bb to
d41073d
Compare
d41073d to
6b5949b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5430 +/- ##
==========================================
- Coverage 65.30% 65.25% -0.05%
==========================================
Files 213 213
Lines 33915 33915
==========================================
- Hits 22147 22131 -16
- Misses 10438 10449 +11
- Partials 1330 1335 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
test/fuzz/ir_fuzz_test.go
Outdated
| return | ||
| } | ||
|
|
||
| if resources.GatewayClass == nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see LoadResourcesFromYAMLBytes actually adds a default GatewayClass if it doesn't exist, so this check may not be needed.
test/fuzz/ir_fuzz_test.go
Outdated
| if err != nil { | ||
| return | ||
| } | ||
| rs, err := resource.LoadResourcesFromYAMLBytes(yamlBytes, true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also have go-fuzz-headers generate the 2nd bool value, instead of hardcoding it to true? Would be good to test this function under both cases.
6b5949b to
9e5a890
Compare
9e5a890 to
b5135b6
Compare
Signed-off-by: sudipto baral <[email protected]>
Signed-off-by: sudipto baral <[email protected]>
b5135b6 to
a06bd97
Compare
arkodg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks !
What type of PR is this?
Implement fuzzers to target translateGatewayAPIToIR.
Which issue(s) this PR fixes:
Fixes #5428
Release Notes: No