Skip to content

conformance: skip, skip-test features #5399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arkodg merged 1 commit into from
Mar 4, 2025
Merged

conformance: skip, skip-test features #5399

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion internal/gatewayapi/conformance/suite.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,12 @@
tests.GatewayInfrastructure,
}

// SkipFeatures is a list of features that are skipped in the conformance report.
var SkipFeatures = sets.New[features.FeatureName](
features.GatewayStaticAddressesFeature.Name,
features.GatewayInfrastructurePropagationFeature.Name,
)

func skipTestsShortNames(skipTests []suite.ConformanceTest) []string {
shortNames := make([]string, len(skipTests))
for i, test := range skipTests {
Expand All @@ -36,7 +42,10 @@
func allFeatures() sets.Set[features.FeatureName] {
allFeatures := sets.New[features.FeatureName]()
for _, feature := range features.AllFeatures.UnsortedList() {
allFeatures.Insert(feature.Name)
// Dont add skipped features in the conformance report.
if !SkipFeatures.Has(feature.Name) {
allFeatures.Insert(feature.Name)
}

Check warning on line 48 in internal/gatewayapi/conformance/suite.go

View check run for this annotation

Codecov / codecov/patch

internal/gatewayapi/conformance/suite.go#L45-L48 

Added lines #L45 - L48 were not covered by tests
}
return allFeatures
}
Expand Down