Skip to content

feat: implement HTTPUpgrade in BTP#5374

Merged
zirain merged 10 commits intoenvoyproxy:mainfrom
zirain:impl/upgrade-configs
Mar 13, 2025
Merged

feat: implement HTTPUpgrade in BTP#5374
zirain merged 10 commits intoenvoyproxy:mainfrom
zirain:impl/upgrade-configs

Conversation

@zirain
Copy link
Member

@zirain zirain commented Feb 28, 2025

xref: #5300
fixes: #4859 #5276

@zirain zirain requested a review from a team as a code owner February 28, 2025 07:47
@codecov
Copy link

codecov bot commented Feb 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.30%. Comparing base (bfd239b) to head (d018b6c).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5374      +/-   ##
==========================================
- Coverage   65.31%   65.30%   -0.01%     
==========================================
  Files         213      213              
  Lines       33942    33956      +14     
==========================================
+ Hits        22168    22175       +7     
- Misses      10447    10453       +6     
- Partials     1327     1328       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zirain zirain force-pushed the impl/upgrade-configs branch 4 times, most recently from 97d0260 to 0cc7d38 Compare March 5, 2025 03:13
@zhaohuabing
Copy link
Member

Does this PR also address the HTTP CONNECT use case? Or HTTP CONNECT will be supported in a follow-up PR?

@arkodg
Copy link
Contributor

arkodg commented Mar 5, 2025

Does this PR also address the HTTP CONNECT use case? Or HTTP CONNECT will be supported in a follow-up PR?

hey @zhaohuabing I plan on addressing that in a follow up PR

@zirain zirain force-pushed the impl/upgrade-configs branch from 0cc7d38 to 9de15af Compare March 6, 2025 02:33
@zirain zirain force-pushed the impl/upgrade-configs branch from 9de15af to 718a8e1 Compare March 7, 2025 05:55
@zirain zirain requested a review from arkodg March 7, 2025 05:56
@zirain zirain force-pushed the impl/upgrade-configs branch from a0c6109 to b2546fe Compare March 12, 2025 03:16
@zirain zirain requested review from arkodg, guydc and zhaohuabing March 12, 2025 09:48
@zirain zirain requested a review from arkodg March 13, 2025 02:03
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@arkodg arkodg requested review from a team March 13, 2025 02:10
zirain added 5 commits March 13, 2025 10:16
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
zirain added 5 commits March 13, 2025 10:16
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
@zirain zirain force-pushed the impl/upgrade-configs branch from b5b1c1c to d018b6c Compare March 13, 2025 02:16
@zirain zirain merged commit 15b31fb into envoyproxy:main Mar 13, 2025
27 of 28 checks passed
@zirain zirain deleted the impl/upgrade-configs branch March 13, 2025 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

support other upgradeTypes then just websocket

4 participants