api: Support ForwardUsernameHeader field in the BasicAuth#5342
Merged
zirain merged 3 commits intoenvoyproxy:mainfrom Feb 28, 2025
Merged
api: Support ForwardUsernameHeader field in the BasicAuth#5342zirain merged 3 commits intoenvoyproxy:mainfrom
zirain merged 3 commits intoenvoyproxy:mainfrom
Conversation
zirain
reviewed
Feb 24, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5342 +/- ##
==========================================
- Coverage 65.11% 65.03% -0.09%
==========================================
Files 213 213
Lines 33586 33586
==========================================
- Hits 21869 21842 -27
- Misses 10392 10411 +19
- Partials 1325 1333 +8 ☔ View full report in Codecov by Sentry. |
Member
|
please run |
Contributor
|
|
Contributor
Author
Signed-off-by: Suren Raju <suren.1988@gmail.com>
Signed-off-by: Suren Raju <suren.1988@gmail.com>
Signed-off-by: Suren Raju <suren.1988@gmail.com>
d75cfb1 to
0ba4d1d
Compare
zirain
approved these changes
Feb 28, 2025
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Type of PR
Feature
What this PR does / why we need it:
#2947
This PR introduces the
ForwardUsernameHeaderfield in theBasicAuthsection ofSecurityPolicy. It enables the Envoy to forward the username of a successfully authenticated user to the backend services via a specified HTTP header.The field is optional. If it's not specified, the username will not be forwarded.
Which issue(s) this PR fixes:
Fixes 2947
User-Facing Changes
Added
ForwardUsernameHeaderinBasicAuthofSecurityPolicyto enable username forwarding to backend services.Release Notes: No