feat: support adding additional labels to dashboard configmap#5317
feat: support adding additional labels to dashboard configmap#5317arkodg merged 1 commit intoenvoyproxy:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5317 +/- ##
=======================================
Coverage 64.96% 64.97%
=======================================
Files 213 213
Lines 33474 33474
=======================================
+ Hits 21747 21750 +3
+ Misses 10398 10396 -2
+ Partials 1329 1328 -1 ☔ View full report in Codecov by Sentry. |
5e59a9c to
a87426d
Compare
There was a problem hiding this comment.
can we use dashboard here ? because the object is not an array/map type
There was a problem hiding this comment.
although the generated object is a single ConfigMap, but it creates multiple grafana dashboards, doesn't it? so I think using the plural form is more accurate.
There was a problem hiding this comment.
In the project we use plural only when the type of the object is array/map, this field is referring to the dashboard configuration
There was a problem hiding this comment.
okay, it's been done.
Signed-off-by: fengxsong <fengxsong@outlook.com>
dcb01e8 to
e9e6233
Compare
What type of PR is this?
What this PR does / why we need it:
If we use this chart along with a tool like https://github.com/kiwigrid/k8s-sidecar to automatically manage dashboards, this tool requires explicitly adding labels like 'grafana_dashboard: ""' to the ConfigMap.