Skip to content

feat: support adding additional labels to dashboard configmap#5317

Merged
arkodg merged 1 commit intoenvoyproxy:mainfrom
fengxsong:dashboard_cm_labels
Feb 25, 2025
Merged

feat: support adding additional labels to dashboard configmap#5317
arkodg merged 1 commit intoenvoyproxy:mainfrom
fengxsong:dashboard_cm_labels

Conversation

@fengxsong
Copy link
Copy Markdown
Contributor

What type of PR is this?

  • "feat(chart): Support adding additional labels to the dashboard ConfigMap."

What this PR does / why we need it:

If we use this chart along with a tool like https://github.com/kiwigrid/k8s-sidecar to automatically manage dashboards, this tool requires explicitly adding labels like 'grafana_dashboard: ""' to the ConfigMap.

@fengxsong fengxsong requested a review from a team as a code owner February 19, 2025 11:11
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.97%. Comparing base (1b6bf5f) to head (e9e6233).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5317   +/-   ##
=======================================
  Coverage   64.96%   64.97%           
=======================================
  Files         213      213           
  Lines       33474    33474           
=======================================
+ Hits        21747    21750    +3     
+ Misses      10398    10396    -2     
+ Partials     1329     1328    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

zirain
zirain previously approved these changes Feb 20, 2025
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use dashboard here ? because the object is not an array/map type

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

although the generated object is a single ConfigMap, but it creates multiple grafana dashboards, doesn't it? so I think using the plural form is more accurate.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the project we use plural only when the type of the object is array/map, this field is referring to the dashboard configuration

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, it's been done.

Signed-off-by: fengxsong <fengxsong@outlook.com>
Copy link
Copy Markdown
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@arkodg arkodg requested review from a team and zirain February 25, 2025 00:21
@arkodg arkodg merged commit 236b0d7 into envoyproxy:main Feb 25, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants