Make panic threshold configurable for cluster

[nezdolik]

feat(api): Make panic threshold configurable per backend/cluster
Fixes #4015

Release Notes: TBD

[nezdolik]

oopsie

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.90%. Comparing base (3b18afe) to head (eb1631f).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5118      +/-   ##
==========================================
+ Coverage   66.81%   66.90%   +0.08%     
==========================================
  Files         210      210              
  Lines       32988    32998      +10     
==========================================
+ Hits        22042    22077      +35     
+ Misses       9604     9583      -21     
+ Partials     1342     1338       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[arkodg]

my preference would be to add a PanicThreshold unit32 field inside HealthCheck supporting values between 0-100

gateway/api/v1alpha1/healthcheck_types.go

Line 17 in 0e52d06

type HealthCheck struct {

[nezdolik]

realistically it cannot be < 0 due to uint32 type

[nezdolik]

Error: internal/ir/xds.go:2463:6: SA4003: no value of type uint32 is less than 0 (staticcheck)
		if *h.PanicThreshold < 0 || *h.PanicThreshold > 100 {

CI is smart :)

[nezdolik]

I should be able just to set it to nil

[nezdolik]

there is a failure for conformance test --- FAIL: TestGatewayAPIConformance/HTTPRouteListenerPortMatching (72.08s) with not much additional info

[arkodg]

LGTM thanks !
as a follow up can you add a test case in https://github.com/envoyproxy/gateway/tree/main/internal/xds/translator/testdata/in/xds-ir

[shawnh2]

LGTM

[arkodg]

why is this set twice - here and below ?

[nezdolik]

Good question, error while refactoring

[arkodg]

thanks @nezdolik can you also add a yaml test in https://github.com/envoyproxy/gateway/tree/main/internal/xds/translator/testdata/in/xds-ir and https://github.com/envoyproxy/gateway/tree/main/internal/xds/translator/testdata/out/xds-ir

[arkodg]

LGTM thanks !

[zirain]

Thanks, it would be better if you can add an e2e for this later.