Sort match conditions based on Gateway API Spec#508
Merged
danehans merged 5 commits intoenvoyproxy:mainfrom Oct 7, 2022
Merged
Sort match conditions based on Gateway API Spec#508danehans merged 5 commits intoenvoyproxy:mainfrom
danehans merged 5 commits intoenvoyproxy:mainfrom
Conversation
Sort based on the match precedence defined in https://gateway-api.sigs.k8s.io/references/spec/#gateway.networking.k8s.io%2fv1beta1.HTTPRouteRule Fixes: envoyproxy#436 Fixes: envoyproxy#483 Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Codecov Report
@@ Coverage Diff @@
## main #508 +/- ##
==========================================
- Coverage 63.48% 62.77% -0.71%
==========================================
Files 40 42 +2
Lines 4425 4513 +88
==========================================
+ Hits 2809 2833 +24
- Misses 1471 1534 +63
- Partials 145 146 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
danehans
reviewed
Oct 6, 2022
Contributor
danehans
left a comment
danehans
left a comment
There was a problem hiding this comment.
One nit, otherwise /lgtm.
Alice-Lilith
previously approved these changes
Oct 7, 2022
Member
Alice-Lilith
left a comment
Alice-Lilith
left a comment
There was a problem hiding this comment.
lgtm with a +1 to @danehans's comment
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
danehans
approved these changes
Oct 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sort based on the match precedence defined in
https://gateway-api.sigs.k8s.io/references/spec/#gateway.networking.k8s.io%2fv1beta1.HTTPRouteRule
Fixes: #436 Fixes: #483
Signed-off-by: Arko Dasgupta arko@tetrate.io