Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix osv scanner #4414

Merged
merged 3 commits into from
Oct 9, 2024
Merged

chore: fix osv scanner #4414

merged 3 commits into from
Oct 9, 2024

Conversation

zirain
Copy link
Contributor

@zirain zirain commented Oct 9, 2024

No description provided.

@zirain zirain requested a review from a team as a code owner October 9, 2024 02:19
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.74%. Comparing base (2f67765) to head (17cf712).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4414      +/-   ##
==========================================
+ Coverage   65.70%   65.74%   +0.04%     
==========================================
  Files         200      200              
  Lines       24125    24125              
==========================================
+ Hits        15851    15861      +10     
+ Misses       7139     7133       -6     
+ Partials     1135     1131       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: zirain <[email protected]>
Signed-off-by: zirain <[email protected]>
Copy link
Member

@zhaohuabing zhaohuabing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also ran into this before. It looks like OSC scanner has issues identifying licences for unofficial releases.

@zirain zirain requested review from a team October 9, 2024 05:18
@zirain zirain merged commit 87b8418 into envoyproxy:main Oct 9, 2024
24 checks passed
@zirain zirain deleted the fix-osv-scanner branch October 9, 2024 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants