Updates Infra IR to Support Multiple Envoy Services#389
Closed
danehans wants to merge 1 commit intoenvoyproxy:mainfrom
Closed
Updates Infra IR to Support Multiple Envoy Services#389danehans wants to merge 1 commit intoenvoyproxy:mainfrom
danehans wants to merge 1 commit intoenvoyproxy:mainfrom
Conversation
danehans
added
area/ir
Signed-off-by: danehans <daneyonhansen@gmail.com>
arkodg
reviewed
Sep 14, 2022
| Name: string(listener.Name), | ||
| Protocol: proto, | ||
| ServicePort: servicePort, | ||
| ContainerPort: containerPort, |
Contributor
There was a problem hiding this comment.
you'll also need to create a unique (servicePort, containerPort) tuple to ensure traffic doesnt get multiplexed in the envoy listener
Contributor
Author
|
The community is deciding on the approach to supporting multiple gateways in #349. I marked this as a draft until a decision is made. |
Contributor
Author
|
Closing in favor of #404. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, EG creates a single Kube Service regardless of the number of Gateways. This causes issues with running conformance tests since the base manifests create three Gateways that cannot be collapsed into one. This PR updates the Infra IR to support managing multiple Kube Services by mapping a Gateway to Infra IR Listener and mapping a Gateway listener to Infra IR ListenerPort.
Partially fixes:
#349
#380
#382
Signed-off-by: danehans daneyonhansen@gmail.com