Updates Kube Infra Namespace and Envoy Deployment #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #247 +/- ##
==========================================
- Coverage 57.62% 57.49% -0.13%
==========================================
Files 30 30
Lines 2702 2694 -8
==========================================
- Hits 1557 1549 -8
Misses 1054 1054
Partials 91 91
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
arkodg
reviewed
Aug 25, 2022
Signed-off-by: danehans <[email protected]>
arkodg
reviewed
Aug 25, 2022
| @@ -34,6 +34,8 @@ func NewManager(cfg *config.Server) (*Manager, error) { | |||
| ns, found := os.LookupEnv("ENVOY_GATEWAY_NAMESPACE") | |||
| if found { | |||
| mgr.Infra.Namespace = ns | |||
There was a problem hiding this comment.
nit: would have preferred if this logic was living in internal/infrastructure/kubernetes
arkodg
approved these changes
Aug 25, 2022
skriss
approved these changes
Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Namespacewhen creating a new Kube Infra manager.Fixes: #246
Signed-off-by: danehans [email protected]