Adds Envoy Bootstrap Config #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arkodg
reviewed
Aug 17, 2022
| address: | ||
| socket_address: | ||
| address: {{ .XdsServerAddress }} | ||
| port_value: 18000 |
There was a problem hiding this comment.
#212 tracks this requirement.
arkodg
reviewed
Aug 17, 2022
arkodg
reviewed
Aug 17, 2022
This was referenced Aug 20, 2022
Codecov Report
@@ Coverage Diff @@
## main #206 +/- ##
==========================================
- Coverage 63.60% 63.23% -0.37%
==========================================
Files 27 27
Lines 2349 2358 +9
==========================================
- Hits 1494 1491 -3
- Misses 768 776 +8
- Partials 87 91 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: danehans <[email protected]>
arkodg
approved these changes
Aug 22, 2022
Alice-Lilith
approved these changes
Aug 22, 2022
LukeShu
approved these changes
Aug 23, 2022
| // envoyHTTPPort is the container port number of Envoy's HTTP endpoint. | ||
| envoyHTTPPort = int32(8080) | ||
| // envoyHTTPSPort is the container port number of Envoy's HTTPS endpoint. | ||
| envoyHTTPSPort = int32(8443) | ||
| ) | ||
|
|
||
| var bootstrapTmpl = template.Must(template.New(envoyCfgFileName).Parse(` |
There was a problem hiding this comment.
I'd consider putting this in a separate bootstrap.yaml file and saying
//go:embed bootstrap.yaml
const string bootstrapTmplStr
var bootstrapTmpl = template.Must(template.New(envoyCfgFileName).Parse(bootstrapTmplStr))so that the file is easier to edit, with editors recognizing it as yaml.
Comment on lines
+119
to
+123
| buf := new(bytes.Buffer) | ||
| if err := bootstrapTmpl.Execute(buf, b.parameters); err != nil { | ||
| return fmt.Errorf("failed to render bootstrap config: %v", err) | ||
| } | ||
| b.rendered = buf.String() |
There was a problem hiding this comment.
If we never need access it as a []byte or mutate it (other than append), then it'd be more efficient to use a strings.Builder instead of a bytes.Buffer.
This was referenced Aug 23, 2022
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for managing Envoy's bootstrap config through a ConfigMap.
Fixes: #201
Signed-off-by: danehans [email protected]