Pluralizes Listener Ports of Proxy Infra IR #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arkodg
reviewed
Aug 1, 2022
|
We might want to pluralize the combination of address and port, it is a common use case in IPv6/v4 dual stack etc. |
Signed-off-by: danehans <[email protected]>
danehans
force-pushed
the
infra_ir_update
branch
from
8962a77
to
efb7790
Compare
|
I'm not saying we should do IPv6 support right now, but if we pluralize ports only now it will be messy when we pluralize address. Since this is just IR not an API so it is up to you. |
youngnick
approved these changes
Aug 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, a listener could only have a single port. This PR pluralizes
infra.proxy.listeners[].portsso a listener can have multiple ports.Signed-off-by: danehans [email protected]