filter: Add cache utility functions for HTTP Cache Filter #868#9866
Merged
mattklein123 merged 3 commits intoenvoyproxy:masterfrom Jan 29, 2020
Merged
filter: Add cache utility functions for HTTP Cache Filter #868#9866mattklein123 merged 3 commits intoenvoyproxy:masterfrom
mattklein123 merged 3 commits intoenvoyproxy:masterfrom
Conversation
…a cache entry's effective max age. Signed-off-by: Todd Greer <tgreer@google.com>
toddmgreer
changed the title
…w building. Signed-off-by: Todd Greer <tgreer@google.com>
mattklein123
requested changes
Jan 29, 2020
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
LGTM, thanks, other than opening some follow up issues and linking to them in TODOs.
/wait
Signed-off-by: Todd Greer <tgreer@google.com>
Contributor
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Add cache utility functions for parsing an HTTP time and determining a cache entry's effective max age. C++ files copied verbatim from #7198.
Risk Level: Low: Adds new functions that aren't called.
Testing: New unit tests
Docs Changes: None
Release Notes: None
#868