proto: use anyConvertAndValidate where applicable#9726
Merged
mattklein123 merged 3 commits intoenvoyproxy:masterfrom Jan 19, 2020
junr03:any-convert
Merged
proto: use anyConvertAndValidate where applicable#9726mattklein123 merged 3 commits intoenvoyproxy:masterfrom junr03:any-convert
mattklein123 merged 3 commits intoenvoyproxy:masterfrom
junr03:any-convert
Conversation
added 2 commits
January 17, 2020 15:19
Signed-off-by: Jose Nino <jnino@lyft.com>
mattklein123
previously approved these changes
Jan 17, 2020
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Awesome cleanup, thank you!
Member
Author
|
thanks for the suggestion! I'll merge when tests pass. |
htuch
previously approved these changes
Jan 18, 2020
Member
htuch
left a comment
htuch
left a comment
There was a problem hiding this comment.
Feel free to merge, but if you need to do another push, please fix nit.
mattklein123
approved these changes
Jan 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: #9516 introduced
anyConvertAndValidate. This PR changes call sites to the new function where applicable.Risk Level: low. Logic remains the same just cleaning up double function calls for one.
Testing: CI. Also added unit test for
anyConvertAndValidateFixes #9712