xDS: type url aggregation by Shikugawa · Pull Request #9649 · envoyproxy/envoy

Shikugawa · 2020-01-10T03:46:44Z

Signed-off-by: shikugawa rei@tetrate.io

Description: This is only refactoring. Aggregated xDS type urls. In previous implementation, loadTypeUrl is scattered on all of xDS subscription classes. That is poor outlook so refactored all of them.

Risk Level: Low
Testing: None
Docs Changes: None
Release Notes: None
[Optional Fixes #Issue] #9468 #9526
[Optional Deprecated:]

Signed-off-by: shikugawa <rei@tetrate.io>

Shikugawa · 2020-01-12T06:22:21Z

@htuch I think it also can be eliminate resources.h which can't specify API version. And this will be useful functionality for seamless api version switching that is required such as fallback api version.

Signed-off-by: shikugawa <rei@tetrate.io>

source/common/config/type_url_loader.h

stale · 2020-01-21T15:55:00Z

This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

Shikugawa · 2020-01-22T01:25:10Z

\nostale

include/envoy/config/discovery_service_base.h

source/common/config/type_url_loader.h

Signed-off-by: shikugawa <rei@tetrate.io>

include/envoy/config/discovery_service_base.h

stale · 2020-02-05T20:38:55Z

This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

Signed-off-by: shikugawa <rei@tetrate.io>

Shikugawa · 2020-02-06T17:55:56Z

@htuch How is this?

junr03 · 2020-02-07T06:34:15Z

@lizan do you mind taking over this?

lizan · 2020-02-07T07:16:52Z

Yes I will take over this.

lizan

Sorry for the delay.

include/envoy/config/BUILD

include/envoy/config/discovery_service_base.h

Signed-off-by: shikugawa <rei@tetrate.io>

lizan

LGTM modulo one net. Thanks!

source/common/router/rds_impl.cc

Signed-off-by: shikugawa <rei@tetrate.io>

Shikugawa · 2020-03-13T16:49:59Z

/retest

repokitteh-read-only · 2020-03-13T16:50:03Z

🤷‍♀️ nothing to rebuild.

🐱

Caused by: a #9649 (comment) was created by @Shikugawa.

see: more, trace.

Shikugawa · 2020-03-13T16:53:14Z

/azp run

azure-pipelines · 2020-03-13T16:53:19Z

Commenter does not have sufficient privileges for PR 9649 in repo envoyproxy/envoy

Signed-off-by: shikugawa <rei@tetrate.io>

htuch

LGTM modulo naming nit.

source/common/config/api_type_oracle.cc

Signed-off-by: shikugawa <rei@tetrate.io>

lizan

LGTM, @htuch?

htuch

Thanks!

Shikugawa added 4 commits January 10, 2020 03:18

aggregate xDS resource names

6bd8479

Signed-off-by: shikugawa <rei@tetrate.io>

delete unused classes

b548488

Signed-off-by: shikugawa <rei@tetrate.io>

delete unused headers

98d126e

Signed-off-by: shikugawa <rei@tetrate.io>

Kick CI

6aa3332

Signed-off-by: shikugawa <rei@tetrate.io>

mattklein123 assigned htuch Jan 12, 2020

resource name -> type url

f4be81e

Signed-off-by: shikugawa <rei@tetrate.io>

Shikugawa changed the title ~~xDS: resource names aggregation~~ xDS: type url aggregation Jan 12, 2020

fix

77e976e

Signed-off-by: shikugawa <rei@tetrate.io>

Kick CI

1ac3c7f

Signed-off-by: shikugawa <rei@tetrate.io>

htuch reviewed Jan 14, 2020

View reviewed changes

source/common/config/type_url_loader.h Outdated Show resolved Hide resolved

repokitteh-read-only bot added the waiting label Jan 14, 2020

stale bot added the stale stalebot believes this issue/PR has not been touched recently label Jan 21, 2020

stale bot removed the stale stalebot believes this issue/PR has not been touched recently label Jan 22, 2020

htuch reviewed Jan 22, 2020

View reviewed changes

include/envoy/config/discovery_service_base.h Outdated Show resolved Hide resolved

source/common/config/type_url_loader.h Outdated Show resolved Hide resolved

add getResourceName()

7a9cd2f

Signed-off-by: shikugawa <rei@tetrate.io>

repokitteh-read-only bot removed the waiting label Jan 23, 2020

lambdai reviewed Jan 24, 2020

View reviewed changes

include/envoy/config/discovery_service_base.h Outdated Show resolved Hide resolved

yanavlasov requested changes Jan 28, 2020

View reviewed changes

include/envoy/config/discovery_service_base.h Outdated Show resolved Hide resolved

stale bot added the stale stalebot believes this issue/PR has not been touched recently label Feb 5, 2020

fix

217d979

Signed-off-by: shikugawa <rei@tetrate.io>

stale bot removed the stale stalebot believes this issue/PR has not been touched recently label Feb 6, 2020

fix build error

f1cceb5

Signed-off-by: shikugawa <rei@tetrate.io>

junr03 assigned lizan and unassigned htuch Feb 7, 2020

lizan added the no stalebot Disables stalebot from closing an issue label Feb 7, 2020

Shikugawa mentioned this pull request Mar 3, 2020

hardcoded v2 type urls in xds requests #10209

Closed

lizan removed the no stalebot Disables stalebot from closing an issue label Mar 3, 2020

lizan suggested changes Mar 3, 2020

View reviewed changes

include/envoy/config/BUILD Outdated Show resolved Hide resolved

include/envoy/config/discovery_service_base.h Outdated Show resolved Hide resolved

eliminate v2 api lib bundling

3cbf679

Signed-off-by: shikugawa <rei@tetrate.io>

lizan reviewed Mar 12, 2020

View reviewed changes

source/common/router/rds_impl.cc Outdated Show resolved Hide resolved

lizan mentioned this pull request Mar 12, 2020

api: add compile flag to have only one api version in Envoy #10198

Closed

delete unused API_NO_BOOST

e156876

Signed-off-by: shikugawa <rei@tetrate.io>

Kick CI

f0444b7

Signed-off-by: shikugawa <rei@tetrate.io>

htuch reviewed Mar 13, 2020

View reviewed changes

source/common/config/api_type_oracle.cc Outdated Show resolved Hide resolved

Shikugawa added 2 commits March 16, 2020 07:30

rename

26e6ba9

Signed-off-by: shikugawa <rei@tetrate.io>

Kick CI

9bc83dd

Signed-off-by: shikugawa <rei@tetrate.io>

lizan approved these changes Mar 18, 2020

View reviewed changes

htuch approved these changes Mar 18, 2020

View reviewed changes

htuch merged commit ad843aa into envoyproxy:master Mar 18, 2020

Conversation

Shikugawa commented Jan 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Shikugawa commented Jan 12, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

stale bot commented Jan 21, 2020

Uh oh!

Shikugawa commented Jan 22, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stale bot commented Feb 5, 2020

Uh oh!

Shikugawa commented Feb 6, 2020

Uh oh!

junr03 commented Feb 7, 2020

Uh oh!

lizan commented Feb 7, 2020

Uh oh!

lizan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

lizan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Shikugawa commented Mar 13, 2020

Uh oh!

repokitteh-read-only bot commented Mar 13, 2020

Uh oh!

Shikugawa commented Mar 13, 2020

Uh oh!

azure-pipelines bot commented Mar 13, 2020

Uh oh!

htuch left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

lizan left a comment

Choose a reason for hiding this comment

Uh oh!

htuch left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Shikugawa commented Jan 10, 2020 •

edited

Loading

Shikugawa commented Jan 12, 2020 •

edited

Loading