Skip to content

runtime: splitting classes into two files#9576

Merged
alyssawilk merged 1 commit intoenvoyproxy:masterfrom
alyssawilk:move_flags
Jan 7, 2020
Merged

runtime: splitting classes into two files#9576
alyssawilk merged 1 commit intoenvoyproxy:masterfrom
alyssawilk:move_flags

Conversation

@alyssawilk
Copy link
Contributor

Risk Level: n/a (just moving code)
Testing: n/a
Docs Changes: n/a
Release Notes: n/a

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
@alyssawilk
Copy link
Contributor Author

while trying to resussitate #8847 I ended up trying to call disallowedByDefault a few other places in the code base to verify correctness moving from old to new naming.
Turns out that's really hard to do, because you end up in proto dependency loops due to the proto utilities using disallowedByDefault, but runtime_features.h using proto utilities.
Breaking that loop in master to save myself the pain should it come up again.

@mattklein123 mattklein123 self-assigned this Jan 6, 2020
@junr03 junr03 self-assigned this Jan 6, 2020
Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup.

@alyssawilk alyssawilk merged commit e7a7e8b into envoyproxy:master Jan 7, 2020
@sunjayBhatia
Copy link
Member

just an FYI, these changes seem to have not agreed with MSVC/Windows somehow, we will likely report back here or on slack with questions and potentially an additional patch cc @wrowe

@alyssawilk alyssawilk deleted the move_flags branch May 18, 2020 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants