runtime: splitting classes into two files#9576
Merged
alyssawilk merged 1 commit intoenvoyproxy:masterfrom Jan 7, 2020
Merged
Conversation
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Contributor
Author
|
while trying to resussitate #8847 I ended up trying to call disallowedByDefault a few other places in the code base to verify correctness moving from old to new naming. |
Member
|
just an FYI, these changes seem to have not agreed with MSVC/Windows somehow, we will likely report back here or on slack with questions and potentially an additional patch cc @wrowe |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Risk Level: n/a (just moving code)
Testing: n/a
Docs Changes: n/a
Release Notes: n/a