api: link to previous message type package in API BUILD files.#9210
Merged
lizan merged 3 commits intoenvoyproxy:masterfrom Dec 4, 2019
Merged
api: link to previous message type package in API BUILD files.#9210lizan merged 3 commits intoenvoyproxy:masterfrom
lizan merged 3 commits intoenvoyproxy:masterfrom
Conversation
We need to include the descriptors from the previous message version in the build. We opt to do this transitively; when you include v3 of a package, you get the v2 via a transitive dep. This should work based on alwayslink semantics for cc_library. The computation of the deps is based on the previous_message_type annotation, which will allow cross package migrations. Part of envoyproxy#8082. Risk level: Low Testing: Disabled ip_tagging v2 descriptor hack, observed version_integration_test. After the BUILD changes, this now passes again. Signed-off-by: Harvey Tuch <htuch@google.com>
mattklein123
approved these changes
Dec 4, 2019
derekargueta
approved these changes
Dec 4, 2019
lizan
approved these changes
Dec 4, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to include the descriptors from the previous message version in
the build. We opt to do this transitively; when you include v3 of a
package, you get the v2 via a transitive dep. This should work based on
alwayslink semantics for cc_library.
The computation of the deps is based on the previous_message_type
annotation, which will allow cross package migrations.
Part of #8082.
Risk level: Low
Testing: Disabled ip_tagging v2 descriptor hack, observed
version_integration_test. After the BUILD changes, this now passes
again.
Signed-off-by: Harvey Tuch htuch@google.com