tools: removing flag flip tooling#9184
Merged
alyssawilk merged 3 commits intoenvoyproxy:masterfrom Dec 3, 2019
Merged
Conversation
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
alyssawilk
changed the title
alyssawilk
changed the title
jmarantz
approved these changes
Dec 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We decided last release to set flags true by default. Between that and some changes for #8992 (insisting on flags being true by default) we no longer need a flag flipping script.
Instead, flags will be true by default, and the rare exceptions (codec swapping) can be handled on a case by case basis with tooling in #8992
Minor cleanup to dependencies and stringifification so one can use the instructions to run the script (i wasn't updated to python 3)
Risk Level: none (tooling)
Testing: manual
Docs Changes: n/a