grpc: Allow user defined grpc status#8886
Merged
lizan merged 10 commits intoenvoyproxy:masterfrom Nov 11, 2019
Merged
Conversation
Shikugawa
requested review from
dio,
lizan,
snowp and
zuercher
as code owners
Signed-off-by: Shikugawa <Shikugawa@gmail.com>
Signed-off-by: Shikugawa <Shikugawa@gmail.com>
Shikugawa
force-pushed
the
allow-user-defined-grpc-status
branch
from
0d0bc6a to
e8d8ed0
Compare
lizan
reviewed
Nov 5, 2019
Member
lizan
left a comment
lizan
left a comment
There was a problem hiding this comment.
LGTM except the use of UserDefinedGrpcStatus
yanavlasov
requested changes
Nov 5, 2019
…rpc-json transcoder Signed-off-by: Shikugawa <Shikugawa@gmail.com>
Shikugawa
added a commit
to Shikugawa/envoy
that referenced
this pull request
Nov 6, 2019
Signed-off-by: Shikugawa <Shikugawa@gmail.com>
yanavlasov
requested changes
Nov 6, 2019
source/extensions/filters/http/grpc_json_transcoder/json_transcoder_filter.cc
Show resolved
Hide resolved
…acceptable mode Signed-off-by: Shikugawa <Shikugawa@gmail.com>
Member
|
@Shikugawa can you merge master and resolve conflicts? |
Signed-off-by: Shikugawa <Shikugawa@gmail.com>
lizan
reviewed
Nov 7, 2019
Signed-off-by: Shikugawa <Shikugawa@gmail.com>
Signed-off-by: Shikugawa <Shikugawa@gmail.com>
Signed-off-by: Shikugawa <Shikugawa@gmail.com>
Signed-off-by: Shikugawa <Shikugawa@gmail.com>
lizan
approved these changes
Nov 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: This fix is a branch of issue #8053. User defined grpc-status is allow on grpc specification so that it is truly handled on envoy grpc-json transcoding
Risk Level: Low
Testing: Unit Test
Docs Changes: none
Release Notes: none
[Optional Fixes #8053]
[Optional Deprecated:]