Skip to content

config: Deprecate google.protobuf.Struct config members followup#8861

Merged
lizan merged 2 commits intoenvoyproxy:masterfrom
yanavlasov:deprecate-struct-2
Nov 3, 2019
Merged

config: Deprecate google.protobuf.Struct config members followup#8861
lizan merged 2 commits intoenvoyproxy:masterfrom
yanavlasov:deprecate-struct-2

Conversation

@yanavlasov
Copy link
Contributor

Deprecate google.protobuf.Struct config members in the following types:
envoy.api.v2.auth.PrivateKeyProvider
envoy.api.v2.listener.UdpListenerConfig
envoy.config.filter.accesslog.v2.ExtensionFilter

Risk Level: Low
Testing: Unit Test
Docs Changes: N/A
Release Notes: N/A
Fixes: #8403

Signed-off-by: Yan Avlasov yavlasov@google.com

envoy.api.v2.auth.PrivateKeyProvider
envoy.api.v2.listener.UdpListenerConfig
envoy.config.filter.accesslog.v2.ExtensionFilter

Signed-off-by: Yan Avlasov <yavlasov@google.com>
@repokitteh-read-only
Copy link

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to api/.

🐱

Caused by: #8861 was opened by yanavlasov.

see: more, trace.

Signed-off-by: Yan Avlasov <yavlasov@google.com>
@yanavlasov yanavlasov marked this pull request as ready for review November 2, 2019 12:51
@yanavlasov yanavlasov requested a review from lizan as a code owner November 2, 2019 12:51
@repokitteh-read-only repokitteh-read-only bot removed the api label Nov 3, 2019
@lizan lizan merged commit d36adbb into envoyproxy:master Nov 3, 2019
@yanavlasov yanavlasov deleted the deprecate-struct-2 branch February 1, 2021 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

re-deprecate opaque Struct config

2 participants