config: Deprecate opaque Struct config, again. by yanavlasov · Pull Request #8472 · envoyproxy/envoy

yanavlasov · 2019-10-03T14:32:00Z

Deprecate opaque Struct config, again.
Fix unit tests to use the google.protobuf.Any

Reverts PR #6346
Fixes #8403

Risk Level: Low
Testing: Unit Tests
Docs Changes: N/A
Release Notes: deprecation notice

Signed-off-by: Yan Avlasov yavlasov@google.com

Fix unit tests to use the google.protobuf.Any Signed-off-by: Yan Avlasov <yavlasov@google.com>

repokitteh-read-only · 2019-10-03T14:32:07Z

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to api/.

🐱

Caused by: #8472 was opened by yanavlasov.

see: more, trace.

yanavlasov · 2019-10-03T15:29:32Z

@lizan , @htuch please take a look at the initial set of changes. I still need to fix two unit tests with --define deprecated_features=disabled and one without.
Let me know if this is moving in the right direction.

…id configuration uses the Any type. Signed-off-by: Yan Avlasov <yavlasov@google.com>

lizan · 2019-10-03T19:45:41Z

Thanks @yanavlasov, this looks great and is definitely in right direction! You also need to run the proto format check fix to reflect in changes v3alpha and update deprecated doc.

Signed-off-by: Yan Avlasov <yavlasov@google.com>

htuch

Awesome.
/wait

docs/root/intro/deprecated.rst

…/extensions/filters/network/thrift_proxy:config_test tests Signed-off-by: Yan Avlasov <yavlasov@google.com>

Signed-off-by: Yan Avlasov <yavlasov@google.com>

yanavlasov · 2019-10-05T11:21:54Z

All tests pass (for now). I've updated docs/root/intro/deprecated.rst Let me know if there is anything else that needs to be done in this PR.
I will work on parsing TypedStruct in config protos next.

htuch · 2019-10-07T04:34:01Z

@yanavlasov looks great, thanks; can we review/merge the PR for TypedStruct first? Usually I would be OK with knowing they are coming at roughly the same time, but we have a lot of other churn with API and we previously had to undeprecate because we didn't have a known solution landed for Any, so treading a bit more carefully this time around.

htuch

Couple of test comments..

test/common/router/config_impl_test.cc

test/integration/integration.cc

Signed-off-by: Yan Avlasov <yavlasov@google.com>

htuch

Awesome, this is such an epic PR. Thanks. LGTM modulo two comments.
/wait

test/extensions/access_loggers/grpc/tcp_grpc_access_log_integration_test.cc

test/integration/integration.cc

test/integration/dynamic_validation_integration_test.cc

stale · 2019-10-18T04:47:10Z

This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

Signed-off-by: Yan Avlasov <yavlasov@google.com>

htuch

Awesome, LGTM, Can you merge master and then we can ship?
/wait

Signed-off-by: Yan Avlasov <yavlasov@google.com>

Deprecate opaque Struct config, again.

9dca78e

Fix unit tests to use the google.protobuf.Any Signed-off-by: Yan Avlasov <yavlasov@google.com>

yanavlasov changed the title ~~Deprecate opaque Struct config, again.~~ config: Deprecate opaque Struct config, again. Oct 3, 2019

yanavlasov marked this pull request as ready for review October 3, 2019 15:27

yanavlasov requested review from alyssawilk, dio, htuch, lizan, mattklein123, snowp and zuercher as code owners October 3, 2019 15:27

Fix //test/integration:dynamic_validation_integration_test when inval…

5adde77

…id configuration uses the Any type. Signed-off-by: Yan Avlasov <yavlasov@google.com>

Remove deprecated proto fields in v3alpha

3105c4f

Signed-off-by: Yan Avlasov <yavlasov@google.com>

mattklein123 assigned lizan Oct 4, 2019

htuch reviewed Oct 4, 2019

View reviewed changes

docs/root/intro/deprecated.rst Show resolved Hide resolved

repokitteh-read-only bot added the waiting label Oct 4, 2019

Fix //test/integration:dynamic_validation_integration_test and //test…

283d2fb

…/extensions/filters/network/thrift_proxy:config_test tests Signed-off-by: Yan Avlasov <yavlasov@google.com>

repokitteh-read-only bot removed the waiting label Oct 4, 2019

yanavlasov added 3 commits October 4, 2019 20:47

Merge branch 'master' into deprecate-struct-v2

01d3a6a

Fix tests after merging master

9438ff4

Signed-off-by: Yan Avlasov <yavlasov@google.com>

Fix format

43c49c6

Signed-off-by: Yan Avlasov <yavlasov@google.com>

htuch reviewed Oct 7, 2019

View reviewed changes

test/common/router/config_impl_test.cc Show resolved Hide resolved

test/integration/integration.cc Outdated Show resolved Hide resolved

Add comment

37a6651

Signed-off-by: Yan Avlasov <yavlasov@google.com>

htuch suggested changes Oct 11, 2019

View reviewed changes

test/extensions/access_loggers/grpc/tcp_grpc_access_log_integration_test.cc Outdated Show resolved Hide resolved

test/integration/integration.cc Outdated Show resolved Hide resolved

test/integration/dynamic_validation_integration_test.cc Outdated Show resolved Hide resolved

repokitteh-read-only bot added the waiting label Oct 11, 2019

stale bot added the stale stalebot believes this issue/PR has not been touched recently label Oct 18, 2019

yanavlasov added 2 commits October 18, 2019 13:42

Merge branch 'master' into deprecate-struct-v2

19acedf

Signed-off-by: Yan Avlasov <yavlasov@google.com>

Address comments

e777575

Signed-off-by: Yan Avlasov <yavlasov@google.com>

stale bot removed the stale stalebot believes this issue/PR has not been touched recently label Oct 22, 2019

repokitteh-read-only bot added api and removed waiting labels Oct 22, 2019

Merge branch 'master' into deprecate-struct-v2

71c4623

htuch previously approved these changes Oct 24, 2019

View reviewed changes

repokitteh-read-only bot added waiting and removed api labels Oct 24, 2019

yanavlasov added 3 commits October 24, 2019 10:19

Fix proto format

9ef331e

Signed-off-by: Yan Avlasov <yavlasov@google.com>

Merge branch 'master' into deprecate-struct-v2

4af1389

Fix unit tests

8fabdf0

Signed-off-by: Yan Avlasov <yavlasov@google.com>

yanavlasov dismissed htuch’s stale review via 8fabdf0 October 24, 2019 14:47

repokitteh-read-only bot added api and removed waiting labels Oct 24, 2019

yanavlasov added 2 commits October 25, 2019 11:14

Merge branch 'master' into deprecate-struct-v2

039b67c

Fix proto format error

cfdb31f

Signed-off-by: Yan Avlasov <yavlasov@google.com>

lizan approved these changes Oct 26, 2019

View reviewed changes

lizan merged commit 2d7e2bb into envoyproxy:master Oct 26, 2019

lizan mentioned this pull request Oct 28, 2019

re-deprecate opaque Struct config #8403

Closed

yanavlasov deleted the deprecate-struct-v2 branch February 1, 2021 19:30

Conversation

yanavlasov commented Oct 3, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

repokitteh-read-only bot commented Oct 3, 2019

Uh oh!

yanavlasov commented Oct 3, 2019

Uh oh!

lizan commented Oct 3, 2019

Uh oh!

htuch left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

yanavlasov commented Oct 5, 2019

Uh oh!

htuch commented Oct 7, 2019

Uh oh!

htuch left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

htuch left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stale bot commented Oct 18, 2019

Uh oh!

htuch left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

yanavlasov commented Oct 3, 2019 •

edited

Loading