ci: update do_ci.sh targets and docs to the bazel test matrix.#837
ci: update do_ci.sh targets and docs to the bazel test matrix.#837mattklein123 merged 21 commits intoenvoyproxy:masterfrom
Conversation
We've lost Mac OS X build information for do_ci.sh, since it's stale and I don't have a way to verify it. Feel free to add in updated info later, but I think it might be better to use Bazel directly here instead of via the container build. Also, the Alpine build is going to atrophy. I'll take an action item to chat with folks about updating this.
| @@ -1,7 +0,0 @@ | |||
| DOCS_OUTPUT_DIR ?= generated/docs | |||
There was a problem hiding this comment.
I'm not sure if anyone was relying on this to test docs locally. If we don't have it already, can we add a short section in the dev docs on how to build/view docs locally?
|
Per offline convo, ASAN build is much faster in bazel vs. cmake. Maybe it's due to parallelism? But also surprised we aren't destroying crappy travis VMs without setting --jobs. |
|
It wasn't doing ASAN on |
|
Ah OK, I had this same problem in our private build. I worked around by symlinking tools/bazel.rc -> envoy/tools/bazel.rc. +1 to building this into the bzl file. |
|
This looks good, but I realized that we have various processing things that are done on the "normal" build like pushing images, etc. I think we need to fix all of that. |
|
Also, do we care to understand why optimized build/test is now so slow? Seems like almost 2x regression from cmake. |
|
I can confirm that locally (not on CI) that a |
|
Looking at individual C++ build commands, I can see the |
|
|
|
Close/reopen due to a flake that might be in |
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
looks good, small docs question, needs master merge when the flake fix merges.
ci/README.md
Outdated
| The output artifacts can be found in `/build/envoy/bazel-bin/source/exe/envoy-static` in the | ||
| container. | ||
|
|
||
| The `do_ci.sh` targets are: |
There was a problem hiding this comment.
Should references to do_ci.sh in the docs be updated to point to run_envoy_docker.sh ?
|
@htuch you should be good to merge master. |
|
@mattklein123 ready for final approval and merge. |
Alpine build was failing, fixed and changed to build even when not pushing to master to catch this next time.
**Description** Before #793, the case where no matching route found was handled in the extproc and the 404 immediate response was returned from there, but after that, it naturally results in the "unreachable" default route and swallowed the indication of no matching and it made it impossible to reason about the 500 error on that case. In other words, this fixes the regression in #793 to return the proper 404 response. --------- Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
2 participants
We've lost Mac OS X build information for do_ci.sh, since it's stale and I don't have a way to
verify it. Feel free to add in updated info later, but I think it might be better to use Bazel
directly here instead of via the container build.