config: WatchMap: match old GrpcMuxImpl's state-of-the-world behavior#8350
Merged
htuch merged 11 commits intoenvoyproxy:masterfrom Sep 26, 2019
Merged
config: WatchMap: match old GrpcMuxImpl's state-of-the-world behavior#8350htuch merged 11 commits intoenvoyproxy:masterfrom
htuch merged 11 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Fred Douglas <fredlas@google.com>
Signed-off-by: Fred Douglas <fredlas@google.com>
Signed-off-by: Fred Douglas <fredlas@google.com>
lambdai
reviewed
Sep 25, 2019
Signed-off-by: Fred Douglas <fredlas@google.com>
Signed-off-by: Fred Douglas <fredlas@google.com>
htuch
reviewed
Sep 25, 2019
htuch
reviewed
Sep 25, 2019
Member
htuch
left a comment
htuch
left a comment
There was a problem hiding this comment.
Thanks, appreciate the fix, just one major comment.
Signed-off-by: Fred Douglas <fredlas@google.com>
Signed-off-by: Fred Douglas <fredlas@google.com>
Signed-off-by: Fred Douglas <fredlas@google.com>
Signed-off-by: Fred Douglas <fredlas@google.com>
Contributor
Author
|
/retest |
|
🤷♀️ nothing to rebuild. |
Contributor
|
/lgtm |
Contributor
Author
|
@htuch ready to merge, I believe |
danzh2010
pushed a commit
to danzh2010/envoy
that referenced
this pull request
Oct 4, 2019
…envoyproxy#8350) In bringing my draft of the delta+SotW xDS unification to a state of compiling+passing tests, I found that WatchMap's SotW handling was missing some special case logic that exists in the existing/old GrpcMuxImpl. Specifically, eliding onConfigUpdate when it would be an "update" from empty to empty, and rejecting a (non-empty) SotW update when the type URL has no watches whatsoever. Added the eliding, but we decided the rejection is unnecessary; WatchMap will still not do it. Risk Level: low Testing: updated watch_map_test Signed-off-by: Fred Douglas <fredlas@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In bringing my draft of the delta+SotW xDS unification to a state of compiling+passing tests, I found that WatchMap's SotW handling was missing some special case logic that exists in the existing/old GrpcMuxImpl. Specifically, eliding onConfigUpdate when it would be an "update" from empty to empty, and rejecting a (non-empty) SotW update when the type URL has no watches whatsoever.
Added the eliding, but we decided the rejection is unnecessary; WatchMap will still not do it.
Risk Level: low
Testing: updated watch_map_test