Skip to content

ci: install glib2 and update ninja to version 1.8.2.#8033

Closed
PiotrSikora wants to merge 1 commit intoenvoyproxy:masterfrom
PiotrSikora:wasm-build_image
Closed

ci: install glib2 and update ninja to version 1.8.2.#8033
PiotrSikora wants to merge 1 commit intoenvoyproxy:masterfrom
PiotrSikora:wasm-build_image

Conversation

@PiotrSikora
Copy link
Copy Markdown
Contributor

@PiotrSikora PiotrSikora commented Aug 24, 2019

Needed for the upcoming V8-based Wasm VM.

Signed-off-by: Piotr Sikora piotrsikora@google.com

@PiotrSikora
ci: install glib2 and update ninja to version 1.8.2.
3280c9a 
Needed for the upcoming V8-based Wasm VM.

Signed-off-by: Piotr Sikora <piotrsikora@google.com>
@PiotrSikora
Copy link
Copy Markdown
Contributor Author

PiotrSikora commented Aug 24, 2019

cc @lizan

moderation
moderation reviewed Aug 24, 2019
View reviewed changes
ci/build_container/build_container_common.sh
&& chmod +x /usr/local/bin/bazel

# ninja
VERSION=1.8.2
Copy link
Copy Markdown
Contributor

@moderation moderation Aug 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.8.2 is from September 2017. Any reason your not using the latest Ninja release 1.9.0? https://github.com/ninja-build/ninja/releases/tag/v1.9.0

Copy link
Copy Markdown
Contributor Author

@PiotrSikora PiotrSikora Aug 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I remember, v1.9.0 was built using newer glibc, and it won't load on CentOS.

@lizan
Copy link
Copy Markdown
Member

lizan commented Aug 25, 2019

WDYT about envoyproxy/envoy-wasm#152, which eliminates the need of this PR for wee8 build.

@lizan lizan self-assigned this Aug 25, 2019
@PiotrSikora
Copy link
Copy Markdown
Contributor Author

PiotrSikora commented Aug 25, 2019

WDYT about envoyproxy/envoy-wasm#152, which eliminates the need of this PR for wee8 build.

Separately from that PR in general, you're right, we could use use_glib=false to remove glib2 dependency, and I completely forgot that we migrated to the ninja binary that's distributed as part of the archive, so we don't need to update it in the build image either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@moderation moderation moderation left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@lizan lizan

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@PiotrSikora @lizan @moderation