xds: apply node identifier optimization#7876
Merged
htuch merged 7 commits intoenvoyproxy:masterfrom Aug 13, 2019
Merged
Conversation
Signed-off-by: Kuat Yessenov <kuat@google.com>
Contributor
Author
|
/assign @htuch |
|
neither of and, API, shepherds can be assigned to this issue. |
Contributor
|
Should this be an opt-in option to protect management servers that have incorrectly relied on node data being present in every request? |
Contributor
Author
|
Yes, of course. My current plan is to add a bool to config source in xDS. |
Signed-off-by: Kuat Yessenov <kuat@google.com>
Signed-off-by: Kuat Yessenov <kuat@google.com>
Signed-off-by: Kuat Yessenov <kuat@google.com>
Contributor
Author
|
Any chance you can take a look at it @htuch? |
htuch
suggested changes
Aug 13, 2019
Member
htuch
left a comment
htuch
left a comment
There was a problem hiding this comment.
LGTM modulo a few nits, thanks.
Signed-off-by: Kuat Yessenov <kuat@google.com>
Contributor
Author
|
This should be ready for review again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kuat Yessenov kuat@google.com
Omit the node identifier from subsequent discovery requests on the same stream.
Restricted to non-incremental xDS for tractability.
Risk Level: low, affects xDS protocol but guarded by an option
Testing: Unit/integration tests are updated
Docs Changes: xDS spec clarification
Release Notes: omit the node identifier from subsequent discovery requests
Fixes: #7860