tools: add comprehensive coverage reporting to router check#7865
Merged
mattklein123 merged 5 commits intoenvoyproxy:masterfrom Aug 14, 2019
Merged
tools: add comprehensive coverage reporting to router check#7865mattklein123 merged 5 commits intoenvoyproxy:masterfrom
mattklein123 merged 5 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Derek Schaller <d_a_schaller@yahoo.com>
Signed-off-by: Derek Schaller <d_a_schaller@yahoo.com>
Member
Author
|
/wait |
Signed-off-by: Derek Schaller <d_a_schaller@yahoo.com>
Member
Author
|
/retest |
|
🔨 rebuilding |
Member
Author
|
@dio @rgs1 @mattklein123 @jyotima mind taking a look at this? It’s an expansion off of #7727 |
mattklein123
requested changes
Aug 12, 2019
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Thanks good stuff, some small comments. It would pretty cool if there was some other way of tracking per-field coverage that was more built-in and less manual, but I can't think of anything.
/wait
Signed-off-by: Derek Schaller <d_a_schaller@yahoo.com>
Member
Author
|
Yeah, I was hoping that it would be possible to make this less manual but couldn't think of anything that was promising. I'm especially not a fan of the vector of On the plus side this increases visibility into what fields on routes are covered. 🎉 |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: add comprehensive coverage reporting to the router check tool.
Risk Level: Low
Testing: Added tests and manually tested
Docs Changes: Included
Release Notes: Included