fuzz: add a simple fuzzer for xxhash utilities#7855
Merged
mattklein123 merged 3 commits intoenvoyproxy:masterfrom Aug 12, 2019
Merged
fuzz: add a simple fuzzer for xxhash utilities#7855mattklein123 merged 3 commits intoenvoyproxy:masterfrom
mattklein123 merged 3 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Asra Ali <asraa@google.com>
htuch
reviewed
Aug 9, 2019
Member
htuch
left a comment
htuch
left a comment
There was a problem hiding this comment.
Looks great, thanks. One comment before merging.
test/common/common/BUILD
Outdated
| name = "hash_fuzz_test", | ||
| srcs = ["hash_fuzz_test.cc"], | ||
| corpus = "hash_corpus", | ||
| # Fuzzer is stable, no bugs, simple test target; avoid emitting CO2. |
Member
There was a problem hiding this comment.
Did you consider letting it run for some amount of time on ClusterFuzz? What about catching regressions as we bump our version dependency?
Contributor
Author
There was a problem hiding this comment.
Could definitely do, I thought about following this PR with some regressions from local bazel/libfuzzer runs since it's relatively low risk, but I'll remove that tag and let it run!
Signed-off-by: Asra Ali <asraa@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fuzzer tests our hash utilities. Line coverage from source/common/common/hash.h and hash.cc is 89%.
Risk level: Low
Testing: Starting dummy corpus added.